Open
Conversation
Member
|
I have no idea if check is correct but it looks simple and valid. For storing certificate I propose that you make a new class called CertificateStoreInMemory or similar with a few methods like add_certicate an check_certificate (cert) and set_checker. Then add a method to InternalServer called set_certicate_store.Thus people can make their own implementation later. The certificate validation itself should be done in InternalServer or wherever you think is best |
Member
|
Maybe make a CertificateStoreInterface too with all methods raising NotImplemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verifing clients's public certificate and public key before establishing a secure connection