Check if GTest is available before downloading#9
Open
bkmgit wants to merge 1 commit into
Open
Conversation
Author
|
This is similar to #1 though gmock needs to be linked in a similar manner to gtest_main on newer CMake versions. |
|
Does your PR supersede |
Member
|
I think we should be using the |
bkmgit
force-pushed
the
bkmgit-patch-1
branch
from
d411ab3 to
68628a2
Compare
Author
Member
|
@bkmgit if this is still something you're interested in pursuing, can you rebase? FreeCAD itself is going to drop all the FetchContent calls and simply make gtest a system requirement if you want to build the tests, so we could also make that change here, instead. |
Author
|
@chennes Done. |
Member
|
@aiksiongkoh do you want to test this to make sure it works on your development environment before we merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable use of GTest that is already available.