-
Notifications
You must be signed in to change notification settings - Fork 10
Increase ruff's target python version to 3.12 #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.33%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 76.25% 76.33% +0.07%
==========================================
Files 124 124
Lines 2733 2725 -8
Branches 475 475
==========================================
- Hits 2084 2080 -4
+ Misses 452 447 -5
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
greenc-FNAL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: it's more straightforward to add target-version to pyproject.toml
Found it, and it says 3.10 indeed. :) But it also affects the python files in the test directory which aren't part of any project. |
|
|
I started over. :) Let's try this one simple change and see how that goes. |
Increase ruff's target python version to 3.12. The default is 3.10, but out minimum required Python version (in spack etc.) is 3.12. This simplifies code development by allowing 3.12 language constructs.