Skip to content

Conversation

@wlav
Copy link
Contributor

@wlav wlav commented Jan 9, 2026

Increase ruff's target python version to 3.12. The default is 3.10, but out minimum required Python version (in spack etc.) is 3.12. This simplifies code development by allowing 3.12 language constructs.

@wlav wlav requested a review from greenc-FNAL January 9, 2026 23:35
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.33%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   76.25%   76.33%   +0.07%     
==========================================
  Files         124      124              
  Lines        2733     2725       -8     
  Branches      475      475              
==========================================
- Hits         2084     2080       -4     
+ Misses        452      447       -5     
- Partials      197      198       +1     
Flag Coverage Δ
unittests 76.33% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1168a...c0f7989. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@greenc-FNAL greenc-FNAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: it's more straightforward to add target-version to pyproject.toml

@wlav
Copy link
Contributor Author

wlav commented Jan 12, 2026

FYI: it's more straightforward to add target-version to pyproject.toml

Found it, and it says 3.10 indeed. :) But it also affects the python files in the test directory which aren't part of any project.

@greenc-FNAL
Copy link
Contributor

FYI: it's more straightforward to add target-version to pyproject.toml

Found it, and it says 3.10 indeed. :) But it also affects the python files in the test directory which aren't part of any project.

ruff uses pyproject.toml as an .rc file it seems, independent of any other use of said file.

@wlav
Copy link
Contributor Author

wlav commented Jan 12, 2026

I started over. :) Let's try this one simple change and see how that goes.

@greenc-FNAL greenc-FNAL merged commit cadce43 into Framework-R-D:main Jan 13, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants