Python coverage improvements #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| config[42] # should raise | ||
| assert not "did not raise TypeError" | ||
| except TypeError: |
Check notice
Code scanning / CodeQL
Empty except Note test
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (76.93%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 76.25% 76.93% +0.68%
==========================================
Files 124 124
Lines 2733 2736 +3
Branches 475 475
==========================================
+ Hits 2084 2105 +21
+ Misses 452 439 -13
+ Partials 197 192 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
||
| class AddableProtocol[T](Protocol): | ||
| """Typer bound for any types that can be added.""" | ||
| def __add__(self, other: T) -> T: ... # noqa: D105 |
Check notice
Code scanning / CodeQL
Statement has no effect Note test
Copilot AI
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 12, 2026
- Added variant.py helper from PR Framework-R-D#245 - Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable - Updated adder.py to use Variant helper for type-specific registration - Removed debug print statements from verify_extended.py - Removed commented-out mutex code from modulewrap.cpp - Removed debug message() calls from CMakeLists.txt - Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔) Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 12, 2026
…er-in-pull-213 Integrate Variant helper from PR Framework-R-D#245 for type-specific Python algorithm registration
greenc-FNAL
added a commit
to greenc-FNAL/phlex
that referenced
this pull request
Jan 12, 2026
- Added variant.py helper from PR Framework-R-D#245 - Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable - Updated adder.py to use Variant helper for type-specific registration - Removed debug print statements from verify_extended.py - Removed commented-out mutex code from modulewrap.cpp - Removed debug message() calls from CMakeLists.txt - Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔) Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to Python test coverage and fixes for issues thus uncovered. This code introduces a helper for annotating the same Python function for different C++ types, which is similar functionality as is being provided by #213, which would benefit from this helper.