-
Notifications
You must be signed in to change notification settings - Fork 10
Use find_package arguments to mandate NumPy
#219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@phlexbot format |
|
No automatic clang-format fixes were necessary. |
|
Automatic cmake-format fixes pushed (commit e69700a). |
|
@phlexbot format |
|
No automatic clang-format fixes were necessary. |
|
Automatic cmake-format fixes pushed (commit dee425d). |
c9e6b86 to
fad1051
Compare
a46baab to
38bdb27
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (65.51%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #219 +/- ##
==========================================
- Coverage 76.66% 75.67% -0.99%
==========================================
Files 124 124
Lines 2725 2902 +177
Branches 475 507 +32
==========================================
+ Hits 2089 2196 +107
- Misses 442 487 +45
- Partials 194 219 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This change allows a CMake-only replacement to introducing numpy build dependencies. Also included is the replacement of one find_package(Python3 ...) command with find_package(Python ...) as Python2 is not supported.
48a8109 to
575be3f
Compare
This change allows a CMake-only replacement to introducing numpy build dependencies.
Also included:
VIRTUAL_ENVenvironment variable is availableCMAKE_PREFIX_PATHtosys.path(required due to a Spack infelicity)find_package(Python3 ...)command withfind_package(Python ...)as Python2 is not supported.