Skip to content

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Dec 23, 2025

This change allows a CMake-only replacement to introducing numpy build dependencies.

Also included:

  • The automatic addition of the Python home if the VIRTUAL_ENV environment variable is available
  • The automatic addition of any paths from CMAKE_PREFIX_PATH to sys.path (required due to a Spack infelicity)
  • The replacement of one find_package(Python3 ...) command with find_package(Python ...) as Python2 is not supported.

@knoepfel
Copy link
Member Author

@phlexbot format

@github-actions
Copy link
Contributor

No automatic clang-format fixes were necessary.

@github-actions
Copy link
Contributor

Automatic cmake-format fixes pushed (commit e69700a).
⚠️ Note: Some issues may require manual review and fixing.

@knoepfel
Copy link
Member Author

knoepfel commented Jan 5, 2026

@phlexbot format

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

No automatic clang-format fixes were necessary.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Automatic cmake-format fixes pushed (commit dee425d).
⚠️ Note: Some issues may require manual review and fixing.

@knoepfel knoepfel force-pushed the adjust-python-cmake branch 4 times, most recently from c9e6b86 to fad1051 Compare January 7, 2026 18:55
@knoepfel knoepfel linked an issue Jan 7, 2026 that may be closed by this pull request
@knoepfel knoepfel force-pushed the adjust-python-cmake branch 2 times, most recently from a46baab to 38bdb27 Compare January 8, 2026 22:40
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/python/src/pymodule.cpp 62.96% 2 Missing and 8 partials ⚠️

❌ Your patch status has failed because the patch coverage (65.51%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (75.67%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   76.66%   75.67%   -0.99%     
==========================================
  Files         124      124              
  Lines        2725     2902     +177     
  Branches      475      507      +32     
==========================================
+ Hits         2089     2196     +107     
- Misses        442      487      +45     
- Partials      194      219      +25     
Flag Coverage Δ
unittests 75.67% <65.51%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/python/src/modulewrap.cpp 46.03% <100.00%> (+5.25%) ⬆️
plugins/python/src/pymodule.cpp 60.00% <62.96%> (-4.59%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda0271...e626d52. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel requested review from greenc-FNAL and wlav January 13, 2026 18:14
@knoepfel knoepfel force-pushed the adjust-python-cmake branch from 48a8109 to 575be3f Compare January 13, 2026 21:10
@knoepfel knoepfel requested a review from greenc-FNAL January 13, 2026 22:01
@knoepfel knoepfel merged commit 142188d into Framework-R-D:main Jan 13, 2026
34 of 36 checks passed
@knoepfel knoepfel deleted the adjust-python-cmake branch January 13, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Difficulties when mandating NumPy availability

3 participants