Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
55620b3
fix(gotjunk): Fix icon visibility on map with dark backgrounds
Foundup Nov 8, 2025
9ab1254
fix(gotjunk): Fix classification bug and add duplicate item debugging
Foundup Nov 8, 2025
3a7d635
fix(gotjunk): Add body scroll lock to PigeonMapView
Foundup Nov 8, 2025
488727d
feat(gotjunk): Adaptive sidebar icon visibility on map view
Foundup Nov 8, 2025
60bdd41
fix(gotjunk): Ensure sidebar floats above map with pointer events
Foundup Nov 8, 2025
07bd28d
Resolve merge conflict: keep getButtonStyle() helper for adaptive sty…
Foundup Nov 8, 2025
7161ed4
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
a943e66
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
c533506
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
3cc696a
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
250f696
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
3f48095
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
0cc7992
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
e31d586
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 8, 2025
bc720e4
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
1429b14
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
78c1584
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
8ad26d2
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
435c44a
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
01832ae
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
01fc8e4
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
d7cfb92
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
5cc0b06
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
8a75787
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
0c666cf
Merge branches 'main' and 'main' of https://github.com/Foundup/Foundu…
Foundup Nov 9, 2025
5d8d1d1
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
7edb89d
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
ba94ea4
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
bfe7dfd
docs(gotjunk): Update ModLog with 2025-11-09 session changes
Foundup Nov 9, 2025
cb510aa
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
23d6562
fix(gotjunk): Prevent duplicate item creation race condition
Foundup Nov 9, 2025
302e9b2
Merge branch 'main' of https://github.com/Foundup/Foundups-Agent
Foundup Nov 9, 2025
b7ffe82
feat(gotjunk): Hide camera orb on map view for clean UI
Foundup Nov 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ModLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,21 @@
- Tutorial remains fully visible under all safe-area cutouts (dynamic island/notch) and never overlaps the camera orb or floating controls.
- Z-index contract stays synchronized across code + docs to prevent future layering regressions.
- Users get the same glow/animation styling while regaining unobstructed swipe instructions that satisfy WSP UX guardrails.
- Follow-up tweak (2025-11-10 2nd pass): constrained popup height with safe-area-aware `maxHeight`, tightened typography, and enabled auto-scroll so it never intersects the capture orb even on smaller iPhones.

## [2025-11-10] GotJunk Map Camera Orb Visibility Fix

**Change Type**: UI conditional rendering
**Architect**: Codex (0102)
**WSP References**: WSP 3 (module boundaries), WSP 7 (pre-commit validation), WSP 22 (ModLog), WSP 57 (UI documentation consistency)

### What Changed
- Added a `showCameraOrb` prop to `BottomNavBar` so the capture orb can be toggled off per view.
- Updated `App.tsx` to disable the orb when the map overlay is open or when the user is in the map tab, preventing UI overlap on the GotJunk Map screen.

### Impact
- Map view now shows only map controls (zoom/info/pins) while camera and list views still get the orb immediately.
- WSP 87 navigation guidance preserved: no camera controls rendered during non-camera contexts, avoiding accidental capture actions.

## [2025-11-03] MCP Server First Principles Optimization - 78% Reduction

Expand Down
2 changes: 2 additions & 0 deletions modules/foundups/gotjunk/frontend/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,7 @@ const App: React.FC = () => {
: browseFeed.filter(item => item.classification === classificationFilter);

const currentReviewItem = myDrafts.length > 0 ? myDrafts[0] : null;
const showCameraOrb = !(isMapOpen || activeTab === 'map');

// Handle instructions modal close
const handleInstructionsClose = () => {
Expand Down Expand Up @@ -743,6 +744,7 @@ const App: React.FC = () => {
console.log('🔍 Search clicked');
// TODO: Open search modal
}}
showCameraOrb={showCameraOrb}
/>

{isGalleryOpen && (
Expand Down
42 changes: 23 additions & 19 deletions modules/foundups/gotjunk/frontend/components/BottomNavBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ interface BottomNavBarProps {
setCountdown: React.Dispatch<React.SetStateAction<number>>;
hasReviewItems: boolean;
onSearchClick?: () => void; // Search functionality
showCameraOrb?: boolean;
}

const buttonVariants = {
Expand All @@ -35,6 +36,7 @@ export const BottomNavBar: React.FC<BottomNavBarProps> = ({
setCountdown,
hasReviewItems,
onSearchClick = () => console.log('🔍 Search clicked'),
showCameraOrb = true,
}) => {
const cameraRef = useRef<CameraHandle>(null);
const pressTimerRef = useRef<number | null>(null);
Expand Down Expand Up @@ -118,25 +120,27 @@ export const BottomNavBar: React.FC<BottomNavBarProps> = ({
transition={{ type: 'spring', stiffness: 300, damping: 30 }}
>
{/* Camera Orb - Floating above nav bar */}
<div
className="absolute left-1/2 -translate-x-1/2 bottom-32 flex flex-col items-center"
style={{ zIndex: Z_LAYERS.cameraOrb }}
>
{/* Main capture button with live preview - Intelligent scaling: iPhone 11=143px, iPhone 16=149px */}
<div
className="p-2 bg-gray-800 rounded-full shadow-2xl cursor-pointer"
style={{
width: 'clamp(128px, 16vh, 192px)',
height: 'clamp(128px, 16vh, 192px)'
}}
onMouseDown={handlePressStart}
onMouseUp={handlePressEnd}
onTouchStart={handlePressStart}
onTouchEnd={handlePressEnd}
>
<Camera ref={cameraRef} onCapture={onCapture} captureMode={captureMode} />
</div>
</div>
{showCameraOrb && (
<div
className="absolute left-1/2 -translate-x-1/2 bottom-32 flex flex-col items-center"
style={{ zIndex: Z_LAYERS.cameraOrb }}
>
{/* Main capture button with live preview - Intelligent scaling: iPhone 11=143px, iPhone 16=149px */}
<div
className="p-2 bg-gray-800 rounded-full shadow-2xl cursor-pointer"
style={{
width: 'clamp(128px, 16vh, 192px)',
height: 'clamp(128px, 16vh, 192px)'
}}
onMouseDown={handlePressStart}
onMouseUp={handlePressEnd}
onTouchStart={handlePressStart}
onTouchEnd={handlePressEnd}
>
<Camera ref={cameraRef} onCapture={onCapture} captureMode={captureMode} />
</div>
</div>
)}

{/* Main Nav Bar */}
<div
Expand Down