Skip to content

fix: reset font to default when font file is missing #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Jan 25, 2026
Merged

fix: reset font to default when font file is missing #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions commons/src/main/kotlin/org/fossify/commons/extensions/Context-styling.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ import android.content.pm.PackageManager.COMPONENT_ENABLED_STATE_DISABLED
import android.content.pm.PackageManager.COMPONENT_ENABLED_STATE_ENABLED
import android.content.res.Configuration
import android.graphics.Color
import android.graphics.Typeface
import android.view.ViewGroup
import androidx.loader.content.CursorLoader
import com.google.android.material.color.MaterialColors
import org.fossify.commons.R
import org.fossify.commons.helpers.DARK_GREY
import org.fossify.commons.helpers.FONT_TYPE_CUSTOM
import org.fossify.commons.helpers.FONT_TYPE_SYSTEM_DEFAULT
import org.fossify.commons.helpers.FontHelper
import org.fossify.commons.helpers.MyContentProvider
import org.fossify.commons.helpers.MyContentProvider.GLOBAL_THEME_SYSTEM
Expand Down Expand Up @@ -159,10 +161,9 @@ fun Context.syncGlobalConfig(callback: (() -> Unit)? = null) {
accentColor = it.accentColor

if (it.fontType >= 0 && (fontType != it.fontType || fontName != it.fontName)) {
fontType = it.fontType
fontName = it.fontName
if (it.fontType == FONT_TYPE_CUSTOM && it.fontName.isNotEmpty()) {
ensureFontPresentLocally(it.fontName)
if (it.fontType != FONT_TYPE_CUSTOM || ensureFontPresentLocally(it.fontName)) {
fontType = it.fontType
fontName = it.fontName
}
FontHelper.clearCache()
}
Expand All @@ -175,15 +176,28 @@ fun Context.syncGlobalConfig(callback: (() -> Unit)? = null) {
}
}

validateFontSettings()
callback?.invoke()
}
} else {
baseConfig.isGlobalThemeEnabled = false
baseConfig.showCheckmarksOnSwitches = false
validateFontSettings()
callback?.invoke()
}
}

private fun Context.validateFontSettings() {
if (baseConfig.fontType == FONT_TYPE_CUSTOM) {
val typeface = FontHelper.getTypeface(this)
if (typeface == Typeface.DEFAULT) {
baseConfig.fontType = FONT_TYPE_SYSTEM_DEFAULT
baseConfig.fontName = ""
FontHelper.clearCache()
}
}
}

fun Context.withGlobalConfig(callback: (globalConfig: GlobalConfig?) -> Unit) {
if (!isThankYouInstalled()) {
callback(null)
Expand Down
Loading