fix: allow title and location fields to wrap long text#1178
Open
faraz152 wants to merge 1 commit intoFossifyOrg:mainfrom
Open
fix: allow title and location fields to wrap long text#1178faraz152 wants to merge 1 commit intoFossifyOrg:mainfrom
faraz152 wants to merge 1 commit intoFossifyOrg:mainfrom
Conversation
Remove android:maxLines="1" from event_title and event_location so that long titles and locations wrap across multiple lines instead of being clipped. The fields remain single-line inputs (no newlines), only the visual display now wraps correctly. Fixes FossifyOrg#1177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1177
Both the Title and Location fields in the event editor had
android:maxLines="1", which caused long text to scroll horizontally and be clipped rather than wrapping to a new line.Root cause
android:maxLines="1"on anEditTextforces the field to display only one line of text with overflow hidden. It does not affect input behaviour — users cannot type newlines, but the field should wrap visually when populated with long data from a CalDAV sync.Fix
Remove
android:maxLines="1"fromevent_titleandevent_locationinactivity_event.xml.event_title(inputType="textCapSentences") — single-line input is preserved byinputType; text now wraps visually across lines.event_location(inputType="textCapWords") — same; autocomplete continues to work normally.No Kotlin/Java changes. This is a 2-line XML deletion.
Test plan