This repository was archived by the owner on Feb 19, 2022. It is now read-only.
Rearrange preference order of currentOption text to prefer explicit values passed in via the placeholderText prop first
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearrange preference order of
currentOptiontext to prefer explicit values passed in via theplaceholderTextprop first. Remained changes are spacing from a result of auto-format in VSCODE 😝I believe this order makes more sense. If a parent container sets an explicit prop value, it doesn't make sense for an implicit value generated from the select options to override it.
If a greater degree of control is desired, perhaps we can set another boolean prop to allow the explicit
placeholderTextprop to be preferred?