SDKS-4147: Handle Protect collector in React DaVinci sample app #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancheetah
force-pushed
the
SDKS-4147-react-protect-dv
branch
from
dd84076 to
6f1cb8c
Compare
ryanbas21
reviewed
Jul 16, 2025
| console.error('Missing PingOne environment ID for Protect initialization'); | ||
| } else { | ||
| try { | ||
| protectAPI = await protect({ envId: PINGONE_ENV_ID }); |
Contributor
There was a problem hiding this comment.
I was wondering why we needed the protect api in context... and i guess it dawned on me that we're trying to keep the returned api around in the react app, is that accurate?
Couldn't we avoid needing this in context and just initialize this in the component mapper and pass it down?
I don't love the idea of needing this in context
Contributor
Author
There was a problem hiding this comment.
That is correct. The idea was to show both options: initializing at bootstrap time and initializing when we get the ProtectCollector. This follows the similar pattern found in the react AIC todo app.
Contributor
Author
|
Closing in favor of #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pingidentity.atlassian.net/browse/SDKS-4147
The
INIT_PROTECTflag allows for Protect to be initialized either at bootstrap or when a ProtectCollector is found in the DaVinci flow.DO NOT MERGE: This PR relies on the next release of
@forgerock/davinci-clientand@pingidentity/protect. They are currently installed from a local registry, blocking CI from passing.