Skip to content

fix(davinci-client): fix collector value types and simplify node reducer imports #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ancheetah merged 1 commit into from
May 27, 2026
Merged

fix(davinci-client): fix collector value types and simplify node reducer imports #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/little-lamps-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
'@forgerock/davinci-client': patch
---
Comment on lines +1 to +3
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use a breaking-change bump for this release.

Line 2 sets this as a patch, but this PR removes/renames a public exported type (CollectorInputTypes → CollectorValueTypes). That is a compile-time breaking API change for TypeScript consumers.

Suggested changeset fix 
 ---
-'`@forgerock/davinci-client`': patch
+'`@forgerock/davinci-client`': major
 ---
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
---
'@forgerock/davinci-client': patch
---
---
'`@forgerock/davinci-client`': major
---
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/little-lamps-float.md around lines 1 - 3, The changeset currently
marks '`@forgerock/davinci-client`' as 'patch' but you renamed a public TypeScript
export from CollectorInputTypes to CollectorValueTypes which is a breaking API
change; update the changeset entry to use a breaking bump (change the release
type from 'patch' to 'major' for '`@forgerock/davinci-client`') and include a
short note in the changeset text explaining the exported type rename (mention
CollectorInputTypes → CollectorValueTypes) so release tooling and consumers are
aware it's a breaking change.

Copy link
Copy Markdown
Collaborator Author

@ancheetah ancheetah May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollectorInputTypes hasn't been released yet so this is non-breaking. The patch covers the fix for the DeviceAuthenticationCollector

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ancheetah, that makes sense — if CollectorInputTypes was never part of a published release, renaming it carries no breaking-change risk for consumers, and a patch bump is the right level for the DeviceAuthenticationCollector fix. Thanks for the context!


Fixed collector value types and simplified node reducer imports

### `client.types.ts`

- Added `CollectorValueTypes` union type; replaces inline unions in `updateCollectorValues` action payload (`node.reducer.ts`) and the `update` method return closure (`client.store.ts`).

- Rewrote `CollectorValueType<T>` conditional type: grouped branches by return type (string, boolean, string[], specialized, category catch-alls), added `never` for `ActionCollector` and `NoValueCollector`, and added a `SingleValueAutoCollector` catch-all.

### `node.reducer.ts` / `client.store.ts`

- Replaced ~30 individual collector type imports with `Collectors` (from `node.types`) and `CollectorValueTypes` (from `client.types`), collapsing verbose inline union annotations to single-type references.
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,5 @@ GEMINI.md

# Polaris
.polaris-setup-progress.json
.playwright-mcp
.polaris/
Loading
Loading