Skip to content

chore: publish-only-dist-jc #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanbas21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: publish-only-dist-jc #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/journey-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"main": "./dist/src/index.js",
"module": "./dist/src/index.js",
"types": "./dist/src/index.d.ts",
"files": ["./dist/*"],
Copy link

@coderabbitai coderabbitai bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Correct the files pattern and consider including documentation files.

The pattern "./dist/*" is non-standard for npm's files field:

  • The leading ./ is unnecessary and non-idiomatic
  • The pattern dist/* may not recursively include subdirectories as intended

Use "dist" (which recursively includes all files in the dist directory) or "dist/**" for clarity. Additionally, consider including standard files like README.md and LICENSE if they exist in the package root.

🔎 Recommended fix 
-  "files": ["./dist/*"],
+  "files": [
+    "dist",
+    "README.md",
+    "LICENSE"
+  ],

Note: package.json is included by default and doesn't need to be listed.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"files": ["./dist/*"],
"files": [
"dist",
"README.md",
"LICENSE"
],
🤖 Prompt for AI Agents 
In packages/journey-client/package.json around line 18, the "files" entry uses a
non-idiomatic and non-recursive pattern ("./dist/*"); remove the leading "./"
and replace the value with either "dist" (to include the whole directory
recursively) or "dist/**" if you prefer explicit globbing, and optionally add
"README.md" and "LICENSE" to the array so docs and license are published with
the package.

"scripts": {
"build": "pnpm nx nxBuild",
"lint": "pnpm nx nxLint",
Expand All @@ -28,14 +29,13 @@
"@forgerock/sdk-utilities": "workspace:*",
"@forgerock/storage": "workspace:*",
"@reduxjs/toolkit": "catalog:",
"tslib": "^2.3.0",
"vite": "6.4.1",
"vitest-canvas-mock": "^0.3.3"
"tslib": "^2.3.0"
},
"devDependencies": {
"@vitest/coverage-v8": "^1.2.0",
"vite": "6.4.1",
"vitest": "^1.2.0"
"vitest": "^1.2.0",
"vitest-canvas-mock": "^0.3.3"
Comment on lines 36 to +38
Copy link

@coderabbitai coderabbitai bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Upgrade dependencies to current versions — vite 6.4.1 and vitest ^1.2.0 are significantly outdated.

The current stable vite version is 7.2, and the latest vitest version is 4.0.15 (as of December 2025). Your pinned versions are critically behind:

  • Vite 7 requires Vitest 3.2+ for testing environments, but you have vitest ^1.2.0
  • Vitest 1.2.0 predates Vitest 3 and 4 releases and lacks compatibility with current Vite versions
  • For vitest-canvas-mock, the latest version is 1.1.3 with active maintenance showing at least one new version released in the past 3 months, not 0.3.3

Also address the inconsistency: vite is pinned to 6.4.1 (exact version) while vitest and vitest-canvas-mock use caret ranges. Adopt a consistent versioning strategy across all dev dependencies.

🤖 Prompt for AI Agents 
packages/journey-client/package.json lines 36-38: dev dependencies are pinned to
old/inconsistent versions; update "vite" to "^7.2.0", "vitest" to "^4.0.15", and
"vitest-canvas-mock" to "^1.1.3" (or to the current latest stable), and make
versioning consistent (use caret ranges for all devDependencies), then run
npm/yarn install and adjust vitest/Vite config if required for breaking changes
(e.g., update test environment/config keys to match Vitest 4 and Vite 7
compatibility).

},
"nx": {
"tags": ["scope:package"],
Expand Down
Loading