-
Notifications
You must be signed in to change notification settings - Fork 2
Authenticator App: Update SQLCipher dependency to ensure 16KB support for library #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #149 +/- ##
=============================================
- Coverage 27.06% 27.05% -0.01%
Complexity 825 825
=============================================
Files 287 287
Lines 8300 8304 +4
Branches 1136 1130 -6
=============================================
+ Hits 2246 2247 +1
- Misses 5812 5816 +4
+ Partials 242 241 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a419ec4 to
139b807
Compare
|
|
||
| packaging { | ||
| jniLibs { | ||
| pickFirsts.add("**/*.so") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added because of a duplicate dependency being added which fails the build.
The file that was causing the issue: forgerock-core-4.8.0/jni/arm64-v8a/libtool-file.so
| logger.d("Push storage initialized") | ||
| } catch (e: Exception) { | ||
| coroutineContext.ensureActive() | ||
| currentCoroutineContext().ensureActive() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this because of a suggestion from AS.
| try { | ||
| // Load SQLCipher libraries | ||
| SQLiteDatabase.loadLibs(context) | ||
| System.loadLibrary("sqlcipher") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is as part of the migration suggested by the sqlcipher library.
| androidx-ui-graphics = { module = "androidx.compose.ui:ui-graphics" } | ||
| androidx-sqlite = { group = "androidx.sqlite", name = "sqlite", version = "2.5.2" } | ||
| sqlcipher = { group = "net.zetetic", name = "android-database-sqlcipher", version = "4.5.4" } | ||
| sqlcipher = { group = "net.zetetic", name = "sqlcipher-android", version = "4.12.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version change is the primary change which updates the library to be 16KB compatible.
JIRA Ticket
SDKS-4633
Description
Update SQLCipher dependency and refactor database initialization methods.

This change also required a migration from older version of the library deprecated because of the Android 16KB requirement. More information can be found here. This migration guide shows how to migrate existing library.
I tested this with Oauth and Authentication Journey