refactor(workflow-executor): extract ActionRef/FieldRef, align Ref shapes

[Scra3]

Summary

• Extract ActionRef and FieldRef shared interfaces ({ name, displayName }) from inline types in TriggerActionStepExecutionData and UpdateRecordStepExecutionData
• Replace FieldReadBase (private) with exported FieldRef — FieldReadSuccess/FieldReadError now extend FieldRef
• Rename actionDisplayName/actionName → displayName/name and fieldDisplayName/fieldName → displayName/name for consistency
• Move resolveFieldName to handleFirstCall so the technical field name is stored in pendingUpdate at creation time (no re-resolution in resolveAndUpdate)
• Add missing tests: resolveActionName not-found path, saveStepExecution not-called assertions on WorkflowExecutorError, trigger-action pending action in buildStepSummary
• Export ActionRef, FieldRef, NoActionsError from index; update CLAUDE.md

Test plan

• yarn workspace @forestadmin/workflow-executor test — 144 tests pass
• yarn workspace @forestadmin/workflow-executor build — no errors
• yarn workspace @forestadmin/workflow-executor lint — clean

🤖 Generated with Claude Code

Note

Extract ActionRef/FieldRef types and add UpdateRecordStepExecutor/TriggerRecordActionStepExecutor

• Introduces RecordTaskStepDefinition and RecordTaskStepExecutionData (replacing AiTask* equivalents), and adds FieldRef/ActionRef as shared named-field reference shapes across execution data types.
• Adds two new executors: UpdateRecordStepExecutor (selects a field and value, supports confirmation flow) and TriggerRecordActionStepExecutor (selects and triggers a collection action, supports confirmation flow).
• Extracts shared confirmation-flow logic into a new RecordTaskStepExecutor base class; BaseStepExecutor gains schema caching, selectRecordRef, findField, and getAvailableRecordRefs helpers.
• BaseStepExecutor.execute now catches WorkflowExecutorError and returns a structured error outcome instead of throwing; context.history is renamed to context.previousSteps.
• Risk: AiTaskStepOutcome, AiTaskStepStatus, AiTaskStepExecutionData, and UserInput are removed from the public API; callers must migrate to RecordTask* equivalents.

^{Macroscope summarized c8b9247.}

[macroscopeapp]

🟡 Medium src/index.ts:2

McpTaskStepDefinition is defined and included in the StepDefinition union, but not exported from index.ts. Consumers cannot import this type directly to narrow or type-guard MCP task steps. Consider adding it to the named type exports.

 export type {
   ConditionStepDefinition,
   RecordTaskStepDefinition,
   StepDefinition,
 } from './types/step-definition';

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file packages/workflow-executor/src/index.ts around lines 2-6:

`McpTaskStepDefinition` is defined and included in the `StepDefinition` union, but not exported from `index.ts`. Consumers cannot import this type directly to narrow or type-guard MCP task steps. Consider adding it to the named type exports.

Evidence trail:
packages/workflow-executor/src/index.ts (lines 2-6): exports `ConditionStepDefinition`, `RecordTaskStepDefinition`, `StepDefinition` but not `McpTaskStepDefinition`

packages/workflow-executor/src/types/step-definition.ts (lines 30-35): defines `McpTaskStepDefinition`

packages/workflow-executor/src/types/step-definition.ts (lines 37-40): `StepDefinition` union includes `McpTaskStepDefinition`

[qltysh]

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (9)

Rating	File	% Diff	Uncovered Line #s
	...s/workflow-executor/src/executors/read-record-step-executor.ts	100.0%
	...ges/workflow-executor/src/executors/condition-step-executor.ts	100.0%
	packages/workflow-executor/src/types/step-definition.ts	100.0%
	packages/workflow-executor/src/executors/base-step-executor.ts	100.0%
	...s/workflow-executor/src/executors/record-task-step-executor.ts	100.0%
	...workflow-executor/src/executors/update-record-step-executor.ts	100.0%
	...-executor/src/executors/trigger-record-action-step-executor.ts	100.0%
	packages/workflow-executor/src/errors.ts	100.0%
	packages/workflow-executor/src/index.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.