Skip to content

fix: improve email validation regex and enhance test coverage #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rogeriomq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve email validation regex and enhance test coverage #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/src/validations/valid_email_validation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ extension ValidEmailValidation on SimpleValidationBuilder<String> {
///
SimpleValidationBuilder<String> validEmail({String? message, String? code}) {
return use((value, entity) {
if (RegExp(r'^[\w\.-]+@[a-zA-Z\d\.-]+\.[a-zA-Z]{2,}$').hasMatch(value)) {
if (RegExp(r'^[\w\.-]+@([A-Za-z0-9][A-Za-z0-9\-]*\.)+[A-Za-z]{2,}$')
.hasMatch(value)) {
return null;
}

Expand Down
22 changes: 21 additions & 1 deletion test/src/validations/valid_email_validation_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,30 @@ void main() {
.ruleFor((e) => e.email, key: 'email', label: 'E-mail') //
.validEmailOrNull();

final user = UserNullableModel()..email = null;
final user = UserNullableModel()..email = null;

final result = validator.validate(user);

expect(result.isValid, true);
});

test('valid email validation...', () {
final validator = TestLucidValidator<UserModel>();

validator
.ruleFor((e) => e.email, key: 'email', label: 'E-mail') //
.validEmail();

final user = UserModel()..email = 'test@.123.com';

final result = validator.validate(user);

expect(result.isValid, false);

expect(result.exceptions.length, 1);

final error = result.exceptions.first;

expect(error.message, "'E-mail' is not a valid email address.");
});
}