Switched to PSR-15 middleware for Neos 7.0#8
Conversation
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
I can't test this right now, but thanks a lot for putting so much effort into this It looks great by reading!
I just left a nitpick comment for now
|
@bwaidelich Thank you for your feedback! Just renamed it. |
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
did you rename the files, too? since it doesn't seem so but I might got confused by the github ui
|
The file has also been renamed. What still needs to be rewritten are the tests. I have not yet updated them. |
| * Test case for the BackendUriDimensionPresetDetector | ||
| */ | ||
| class DetectContentSubgraphComponentTest extends FunctionalTestCase | ||
| class DetectContentSubgraphMiddlewareTest extends FunctionalTestCase |
There was a problem hiding this comment.
File needs to be renamed accordingly
Tests/Unit/Http/ContentDimensionLinking/DimensionPresetLinkProcessorResolverTest.php
Show resolved
Hide resolved
ah right. It's just the test file that hasn't been renamed it seems |
|
I updated to 7.0 and it broke neos-dimensionresolver. Found this PR. Is this PR ready for merging? :) |
|
just checked if everything is renamed and it should be save to merge. |
|
Any updates on this? @bwaidelich |
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
no time to test atm, but this looks good by reading. Thanks!
albe
left a comment
albe
left a comment
There was a problem hiding this comment.
Looks okay as far as I can tell.
|
Let's merge 🤞 |
|
Could you please tag this commit, so composer will install it without whining about minimum stability requirements :D ? |
5 participants
Just updated my fork to Neos 7.0 (the one with the resolutionHost feature #3) - It may be helpful to apply the changes here as well.