Skip to content

fix: access to invited workspace#6360

Open
0xi4o wants to merge 2 commits intomainfrom
fix/invited-workspace
Open

fix: access to invited workspace#6360
0xi4o wants to merge 2 commits intomainfrom
fix/invited-workspace

Conversation

@0xi4o
Copy link
Copy Markdown
Contributor

@0xi4o 0xi4o commented May 7, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the workspace user retrieval logic by removing a permission check and switching to a global user ID lookup. The review identified a critical Insecure Direct Object Reference (IDOR) vulnerability resulting from these changes, as any authenticated user could potentially access workspace data for others. The feedback includes a specific code suggestion to restore security by validating the user ID and restricting cross-organization access to administrators.

Comment thread packages/server/src/enterprise/controllers/workspace-user.controller.ts Outdated
Comment thread packages/server/src/enterprise/controllers/workspace-user.controller.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants