feat:687 | smart agents - LocalBackend, StateBackend#6339
Open
jchui-wd wants to merge 10 commits intofeature/SmartAgentsfrom
Open
feat:687 | smart agents - LocalBackend, StateBackend#6339jchui-wd wants to merge 10 commits intofeature/SmartAgentsfrom
jchui-wd wants to merge 10 commits intofeature/SmartAgentsfrom
Conversation
…s. Added a basic StateBackend for read and write and connected it with fs and smart agents for basic testing
- Replace filesystemEnabled() with getSandboxType(); default to 'state' there - createBackend throws on unknown SANDBOX_TYPE instead of silently defaulting - SmartAgent always creates a backend (filesystem is always on per design) - getMimeType: explicit no-dot guard before slicing
Rename state.ts -> StateBackend.ts and protocol.ts -> BackendProtocol.ts to match the packages/components convention (PascalCase for files whose primary export is a same-named class/interface). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…p capabilities - updated fs tools with universal edit_file, list_file, glob_files, and grep_file capabilities, add, and write already existed - Updated systemPromptBuilder with additional fs tools - SmartAgents: synced Statebackend using runTimeState.files to sync mutations and files so data is persisted across execution.
…th mimeTypes and Uint8Array, made sure edit and grep must have minimum string in it before performing action
- Added SANDBOX_LOCAL_PATH incase users want to edit the path - adds MAX_LIST_OBJECTS for glob and grep - pinned 20.12.0 < 21.0.0 to support file system calls
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a LocalBackend implementation for the SmartAgent sandbox, enabling disk-backed file operations with built-in path traversal protections. The changes include a comprehensive test suite, integration into the backend factory, and a narrowing of the supported Node.js engine version. Feedback highlights critical performance and memory concerns in the read and grep methods, where entire files are loaded into memory instead of being processed via streams or chunks. Additionally, an unused helper method toVirtual was identified for removal.
- grep uses readline + createReadStream so peak memory is one line per file, not the whole file - JSDoc no longer claims "Dev-only" — that warning belongs to LocalShellBackend (shell exec), not disk-only access - drop unused toVirtual helper Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Concurrent SmartAgent runs previously shared one global root (`~/.flowise/sandbox` or `SANDBOX_LOCAL_PATH`), causing cross-chat file collisions and EEXIST races on `write` (wx flag). Factory now composes `<base>/<orgSeg>/<flowSeg>/<chatSeg>` via new `buildScopeSegments` helper, mirroring the orgId/chatflowid/chatId hierarchy used by `getFileFromStorage`. SmartAgent passes scope at the call site; StateBackend ignores it (already isolated per execution). LocalBackend constructor unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jchui-wd
commented
May 5, 2026
| }, | ||
| "engines": { | ||
| "node": "^20", | ||
| "node": ">=20.12.0 <21.0.0", |
Contributor
Author
There was a problem hiding this comment.
I purposely bumped this so we can use some fs functionality such as fs.readdir(..., { recursive: true }) using recursive and using Dirent.parentPath.
Let me know if we shouldn't do this and I can create a manual function to manually walk the recursive directories instead
jchui-wd
requested review from
HenryHengZJ,
chloebyun-wd,
harshit-flowise and
mmattu-wd
jchui-wd
changed the base branch from
feat/686-StateBackend
to
feature/SmartAgents
jchui-wd
commented
May 5, 2026
|
|
||
| const runtimeState = options.agentflowRuntime?.state as ICommonObject | ||
| if (startPersistState === true && runtimeState && Object.keys(runtimeState).length) { | ||
| if (runtimeState && Object.keys(runtimeState).length) { |
Contributor
Author
There was a problem hiding this comment.
its safe to remove startPersistState here because it was redundant.
runTimeState is NON EMPTY only if startPersisteState is true
so when Object.keys(runtimeState).length) > 0 already implies that startPersistState is true.
jchui-wd
changed the title
Routes paths to sub-backends by longest matching prefix and translates paths/FilesUpdate keys across the boundary. Wires SANDBOX_TYPE=composite into the factory and includes it under hasStatefulSmartAgent so state persistence still applies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
StateBackend
LocalBackend
CompositeBackend
/scratch)
resolved mount
hasStatefulSmartAgent so executionData still hydrates across messages
Videos
StateBackend Videos Demo
read-write-edit.mp4
read-write-edit.mp4
ls-grep-glob.mp4
ls-grep-glob.mp4
LocalBackend Videos Demo
read-write-gr...b-edit-ls.mp4
read-write-grep-glob-edit-ls.mp4
path-traversal-limits.mp4
path-traversal-limits.mp4
create-read-workspace.mp4
create-read-workspace.mp4
CompositeBackend Videos Demo
CompositeCompositeBackend-Demo.mp4
Gaps