Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces permission-based access control for variables within custom node functions. It adds a canViewVariables check in the controller based on user roles and permissions, which is then passed through the service layer to the execution utility. The utility subsequently sets a skipVariables flag, and the getVars utility is updated to return an empty array when this flag is active. I have no feedback to provide as there are no review comments to evaluate.
igor-magun-wd
approved these changes
May 5, 2026
HenryHengZJ
reviewed
May 7, 2026
| const orgId = req.user?.activeOrganizationId | ||
| const workspaceId = req.user?.activeWorkspaceId | ||
| const apiResponse = await nodesService.executeCustomFunction(req.body, workspaceId, orgId) | ||
| const canViewVariables = !!(req.user?.isOrganizationAdmin || req.user?.permissions?.includes('variables:view')) |
Contributor
There was a problem hiding this comment.
what if the flow contains a custom function node, and being embedded in other website.
can this work? I'd assume we automatically treat the req.user as org admin? need to confirm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.