mini-feat: parse list of URLs in webcrawlers#6305
Open
Mewyii wants to merge 9 commits intoFlowiseAI:mainfrom
Open
mini-feat: parse list of URLs in webcrawlers#6305Mewyii wants to merge 9 commits intoFlowiseAI:mainfrom
Mewyii wants to merge 9 commits intoFlowiseAI:mainfrom
Conversation
…d docstore view are now stored in local storage.
…of urls in the link manager popup that automatically gets parsed.
Co-authored-by: Copilot <copilot@github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a 'Parse Input' feature to the ManageScrapedLinksDialog component, allowing users to extract multiple URLs from a text input. It also includes UI enhancements such as increasing the dialog width, truncating long URLs in the title, and updating labels to reflect the new parsing capability. Feedback was provided regarding the handleParseLinks function, noting that the current implementation is inefficient (O(N^2)) and fails to properly filter out non-URL tokens. A refactor using a Set for uniqueness and a more robust filtering approach was suggested.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new button to all web scraper link managers that splits the input by ; \n or \t so lists of urls can be copy pasted into the input field. Small QOL feature.