Fix Paramater Override Bypass

[christopherholland-workday]

1. Today, if the overrideConfig value included FILE-STORAGE:: it would bypass validations. This PR removes that check as it was only used for overriding - now it will rely on isParameterEnabled like in the other validations
2. Add NODE_OPTIONS as a dangerous env var

Testing

Recreated an issue and ensured it was mitigated locally. Please chat offline with @igor-magun-wd and myself for details.

[gemini-code-assist]

Summary of Changes

Hello @christopherholland-workday, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the system by addressing a potential security bypass in parameter override configurations and strengthening environment variable handling. It ensures that all parameters undergo consistent validation and explicitly marks NODE_OPTIONS as a dangerous environment variable, contributing to a more secure and predictable application environment.

Highlights

• Parameter Validation Logic Refinement: The pull request removes a specific bypass for FILE-STORAGE:: prefixed overrideConfig values, ensuring that all parameters are now consistently subjected to the isParameterEnabled validation check.
• Enhanced Environment Variable Security: The NODE_OPTIONS environment variable has been added to the list of dangerous environment variables, preventing its use in contexts where it could pose a security risk.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two important security fixes. First, it adds NODE_OPTIONS to the list of dangerous environment variables in the MCP tool, preventing potential arbitrary code execution vulnerabilities. Second, it removes a bypass in the parameter override logic that allowed FILE-STORAGE:: values to skip validation, ensuring all overrides are now correctly checked against the isParameterEnabled setting. Both changes are well-implemented and significantly improve the security and consistency of the codebase. The changes look good to me.