-
Notifications
You must be signed in to change notification settings - Fork 1
build: upgrade mvn-compiler-plugin and lombok versions #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughVersion updates in pom.xml: dependencyManagement updates org.projectlombok:lombok from 1.18.24 to 1.18.32, and pluginManagement updates maven-compiler-plugin from 3.7.0 to 3.13.0. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lombok: 1.18.32. Maven-compiler-plugin: 3.13.0. Close #104
415f2ca to
ce53dd5
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pom.xml (1)
96-101: Update Surefire — 2.22.1 is not Java 21–readySurefire 2.22.1 is incompatible with Java 21; upgrade to >=3.2.2. Recommend using 3.5.3 (latest stable as of September 19, 2025).
File: pom.xml (lines 96–101)- <version>2.22.1</version> + <version>3.5.3</version>
🧹 Nitpick comments (4)
pom.xml (4)
38-43: Optional: replace source/target with release for clarity and correctness on JDK 9+.
Reduces toolchain surprises and ensures proper bootclasspath.See diff suggested in the compiler-plugin comment above.
141-157: Consider bumping maven-javadoc-plugin for JDK 21 toolchain stability.
3.3.1 is quite old; 3.6.x+ includes multiple JDK 17/21 fixes.Example:
- <version>3.3.1</version> + <version>3.6.3</version>
175-186: Optional: refresh maven-source-plugin to 3.3.x.
Not critical, but keeps tooling consistent with modern Maven/JDKs.- <version>3.0.1</version> + <version>3.3.0</version>
103-106: maven-compiler-plugin 3.13.0 is a good move for Java 21; prefer maven.compiler.release=17 over source/target.Modern JDKs handle cross-compilation better with the release flag.
Apply in pom.xml :
- <maven.compiler.source>17</maven.compiler.source> - <maven.compiler.target>17</maven.compiler.target> + <maven.compiler.release>17</maven.compiler.release>Verification: ripgrep shows these properties at pom.xml lines 41–42 and the plugin (org.apache.maven.plugins:maven-compiler-plugin:3.13.0) at pom.xml lines 103–106; no other pom.xml overrides were found.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml(2 hunks)
🔇 Additional comments (1)
pom.xml (1)
73-76: Approve Lombok 1.18.32 upgrade — verifiedpom.xml declares org.projectlombok:lombok:1.18.32; module POMs (backend-core-model/pom.xml, backend-core-data-impl/pom.xml, backend-core-business-spring-impl/pom.xml, backend-core-business-impl/pom.xml) reference lombok with provided and do not pin a different version.
mlopezFC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



Lombok: 1.18.32.
maven-compiler-plugin: 3.13.0
Close #104
Summary by CodeRabbit