Skip to content

Conversation

@ngonzalezpazFC
Copy link
Contributor

@ngonzalezpazFC ngonzalezpazFC commented Sep 19, 2025

Lombok: 1.18.32.
maven-compiler-plugin: 3.13.0

Close #104

Summary by CodeRabbit

  • New Features
    • No user-facing features added in this release.
  • Chores
    • Updated build tooling and supporting libraries to current stable versions to improve compatibility and maintainability.
    • Enhances build reliability, reduces compiler warnings, and aligns with modern development environments.
    • Minor performance improvements during compilation and better IDE support.
    • No changes to application behavior or APIs; existing functionality remains unaffected.

@ngonzalezpazFC ngonzalezpazFC self-assigned this Sep 19, 2025
@ngonzalezpazFC ngonzalezpazFC added the enhancement New feature or request label Sep 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 19, 2025

Walkthrough

Version updates in pom.xml: dependencyManagement updates org.projectlombok:lombok from 1.18.24 to 1.18.32, and pluginManagement updates maven-compiler-plugin from 3.7.0 to 3.13.0.

Changes

Cohort / File(s) Summary
Build configuration updates
pom.xml
Updated dependencyManagement entry for org.projectlombok:lombok 1.18.24 → 1.18.32; updated pluginManagement entry for org.apache.maven.plugins:maven-compiler-plugin 3.7.0 → 3.13.0

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title is concise and directly describes the main change in the changeset (upgrading the maven-compiler-plugin and Lombok), matching the pom.xml updates in the raw summary and clearly signalling a build/tooling change. It is specific enough for a teammate scanning history to understand the primary intent without listing files or unnecessary detail.
Linked Issues Check ✅ Passed The PR updates the maven-compiler-plugin to 3.13.0 and Lombok to 1.18.32 in pom.xml which directly targets the JDK21 compilation failure described in issue #104, so the coding changes align with the issue objective. The raw summary shows these are the only changes and they are the expected fixes for incompatible javac internals and Lombok compatibility. Because the changes are in dependencyManagement/pluginManagement, verify they actually apply to the affected module(s) and confirm with a full JDK21 build to ensure the error is resolved.
Out of Scope Changes Check ✅ Passed All changes in the provided summary are limited to version bumps in pom.xml for Lombok and the maven-compiler-plugin, which are directly related to the linked issue and there are no unrelated source or configuration changes present. No modifications outside the scope of addressing the JDK21 compilation problem were detected in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-jdk21-compilation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Lombok: 1.18.32.
Maven-compiler-plugin: 3.13.0.

Close #104
@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
pom.xml (1)

96-101: Update Surefire — 2.22.1 is not Java 21–ready

Surefire 2.22.1 is incompatible with Java 21; upgrade to >=3.2.2. Recommend using 3.5.3 (latest stable as of September 19, 2025).
File: pom.xml (lines 96–101)

-          <version>2.22.1</version>
+          <version>3.5.3</version>
🧹 Nitpick comments (4)
pom.xml (4)

38-43: Optional: replace source/target with release for clarity and correctness on JDK 9+.
Reduces toolchain surprises and ensures proper bootclasspath.

See diff suggested in the compiler-plugin comment above.


141-157: Consider bumping maven-javadoc-plugin for JDK 21 toolchain stability.
3.3.1 is quite old; 3.6.x+ includes multiple JDK 17/21 fixes.

Example:

-        <version>3.3.1</version>
+        <version>3.6.3</version>

175-186: Optional: refresh maven-source-plugin to 3.3.x.
Not critical, but keeps tooling consistent with modern Maven/JDKs.

-        <version>3.0.1</version>
+        <version>3.3.0</version>

103-106: maven-compiler-plugin 3.13.0 is a good move for Java 21; prefer maven.compiler.release=17 over source/target.

Modern JDKs handle cross-compilation better with the release flag.

Apply in pom.xml :

-    <maven.compiler.source>17</maven.compiler.source>
-    <maven.compiler.target>17</maven.compiler.target>
+    <maven.compiler.release>17</maven.compiler.release>

Verification: ripgrep shows these properties at pom.xml lines 41–42 and the plugin (org.apache.maven.plugins:maven-compiler-plugin:3.13.0) at pom.xml lines 103–106; no other pom.xml overrides were found.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3554b56 and ce53dd5.

📒 Files selected for processing (1)
  • pom.xml (2 hunks)
🔇 Additional comments (1)
pom.xml (1)

73-76: Approve Lombok 1.18.32 upgrade — verified

pom.xml declares org.projectlombok:lombok:1.18.32; module POMs (backend-core-model/pom.xml, backend-core-data-impl/pom.xml, backend-core-business-spring-impl/pom.xml, backend-core-business-impl/pom.xml) reference lombok with provided and do not pin a different version.

Copy link
Member

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlopezFC mlopezFC merged commit 2125599 into master Sep 26, 2025
3 checks passed
@mlopezFC mlopezFC deleted the fix-jdk21-compilation branch September 26, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project installation fails with jdk21

3 participants