Skip to content

ci: add jakarta.servlet-api to v25 profile#118

Open
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api
Open

ci: add jakarta.servlet-api to v25 profile#118
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 22, 2026

Close #117

Summary by CodeRabbit

  • Chores
    • Updated build dependencies for Maven profile v25 to improve test environment compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33f59951-ebae-499a-9ee2-89cd48e18df7

📥 Commits

Reviewing files that changed from the base of the PR and between 9a88f78 and 9c8a627.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

This PR adds an explicit test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 Maven profile. Previously, this dependency was transitively provided through vaadin-testbench, but that transitive chain changed in Vaadin 25.1.0-rc2, necessitating an explicit declaration.

Changes

Cohort / File(s) Summary
Maven Dependency Management
pom.xml
Added explicit test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 profile to compensate for removal of transitive dependency in vaadin-testbench-core 10.1.0-rc1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • #MarkdownEditor/29: Addresses the same SerializationTest failure by adding the identical test-scoped jakarta.servlet-api:6.1.0 dependency to the v25 profile.
  • #ChatAssistant/60: Adds the same test-scoped jakarta.servlet:jakarta.servlet-api:6.1.0 dependency to the v25 Maven profile for Vaadin 25.1.x compatibility.
  • #ImageCrop/30: Implements the same fix for SerializationTest failures in Vaadin 25.1.x by explicitly declaring the jakarta.servlet:jakarta.servlet-api dependency.
  • #DayOfWeekSelectorAddon/22: Addresses missing jakarta.servlet classes during tests by adding the same test-scoped dependency to the v25 profile.
  • #ExtendedLoginAddon/30: Fixes jakarta.servlet class resolution failures in Vaadin 25.1.x with the identical explicit dependency addition.
  • #BadgeList/35: Restores missing servlet classes for tests in Vaadin 25.1.x by adding the same jakarta.servlet-api test dependency.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: add jakarta.servlet-api to v25 profile' accurately summarizes the main change in the pull request.
Linked Issues check ✅ Passed The pull request adds the explicit test-scoped jakarta.servlet-api:6.1.0 dependency to the v25 profile as required by issue #117, directly addressing the SerializationTest failure.
Out of Scope Changes check ✅ Passed All changes are within scope; only the v25 profile pom.xml was modified to add the required test dependency, with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v25-jakarta-servlet-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@sonarqubecloud
Copy link

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 22, 2026 15:25
@javier-godoy javier-godoy marked this pull request as ready for review March 22, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

Fix SerializationTest failure with Vaadin 25.1.x

1 participant