Skip to content

ci: add jakarta.servlet-api to v25 profile#30

Open
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api
Open

ci: add jakarta.servlet-api to v25 profile#30
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 22, 2026

Close #29

Summary by CodeRabbit

  • Chores
    • Updated test dependencies for the v25 Maven profile to support the latest Jakarta Servlet API specifications.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: afa2777d-0366-47ea-b485-dccea33ce6ce

📥 Commits

Reviewing files that changed from the base of the PR and between fffe75c and b221e95.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

Added test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 Maven profile in pom.xml. This resolves missing Jakarta Servlet API classes required for test compilation against Vaadin 25.1.

Changes

Cohort / File(s) Summary
Maven Dependency Configuration
pom.xml
Added test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 Maven profile to address transitive dependency removal in vaadin-testbench-core:10.1.0-rc1+.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'ci: add jakarta.servlet-api to v25 profile' directly describes the main change: adding a Jakarta Servlet API dependency to the Maven v25 profile.
Linked Issues check ✅ Passed The pull request adds jakarta.servlet:jakarta.servlet-api:6.1.0 as a test-scoped dependency to the v25 profile, directly addressing the missing dependency causing SerializationTest failures with Vaadin 25.1.0-rc2 as required by issue #29.
Out of Scope Changes check ✅ Passed The pull request contains only the necessary dependency addition to resolve issue #29; no extraneous or unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v25-jakarta-servlet-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy javier-godoy marked this pull request as ready for review March 22, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api

1 participant