Skip to content

ci: add jakarta.servlet-api to v25 profile#23

Open
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api
Open

ci: add jakarta.servlet-api to v25 profile#23
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 22, 2026

Close #22

Summary by CodeRabbit

  • Chores
    • Updated test dependencies to improve compatibility and testing capabilities.

Note: This release contains no user-facing changes. Updates are focused on internal tooling and infrastructure.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 894facb7-f150-4ac2-86e9-da9d7620ff09

📥 Commits

Reviewing files that changed from the base of the PR and between f354232 and 3ee9a4c.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

The pull request adds an explicit test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the Maven v25 profile in pom.xml. This restores a previously-transitive dependency that was removed in a newer version of vaadin-testbench-core.

Changes

Cohort / File(s) Summary
Jakarta Servlet API Dependency
pom.xml
Added test-scoped dependency on jakarta.servlet:jakarta.servlet-api:6.1.0 to the v25 profile to resolve missing jakarta.servlet classes at test runtime.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding jakarta.servlet-api to the v25 profile.
Linked Issues check ✅ Passed The PR adds jakarta.servlet:jakarta.servlet-api:6.1.0 as a test-scoped dependency to the v25 profile, directly addressing issue #22's requirement to fix SerializationTest failures with Vaadin 25.1.
Out of Scope Changes check ✅ Passed The changes are limited to adding a single test-scoped dependency to the v25 profile in pom.xml, which is directly aligned with the linked issue's requirements with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v25-jakarta-servlet-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 22, 2026 15:43
@sonarqubecloud
Copy link

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy javier-godoy marked this pull request as ready for review March 22, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api

1 participant