Skip to content

ci: add jakarta.servlet-api to v25 profile#36

Open
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api
Open

ci: add jakarta.servlet-api to v25 profile#36
javier-godoy wants to merge 1 commit intomasterfrom
fix/v25-jakarta-servlet-api

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 22, 2026

Close #35

Summary by CodeRabbit

  • Chores
    • Updated build configuration for test environment compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 74c16a79-ab79-4f2b-ab77-7d8583c458ce

📥 Commits

Reviewing files that changed from the base of the PR and between f175086 and af48c0a.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

A test-scoped Maven dependency jakarta.servlet:jakarta.servlet-api:6.1.0 was added to the v25 profile in pom.xml to resolve test runtime failures caused by a missing transitive dependency removed in Vaadin 25.1.x.

Changes

Cohort / File(s) Summary
Maven Dependency
pom.xml
Added test-scoped jakarta.servlet:jakarta.servlet-api:6.1.0 dependency to the v25 profile to restore a transitive dependency no longer provided by vaadin-testbench-unit.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding jakarta.servlet-api to the v25 profile in the build configuration.
Linked Issues check ✅ Passed The pull request implements the exact fix specified in issue #35: adding jakarta.servlet:jakarta.servlet-api:6.1.0 as a test-scoped dependency to the v25 profile in pom.xml.
Out of Scope Changes check ✅ Passed All changes are directly scoped to resolving the SerializationTest failure by adding the required jakarta.servlet-api dependency with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v25-jakarta-servlet-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 22, 2026 15:42
@sonarqubecloud
Copy link

@javier-godoy javier-godoy marked this pull request as ready for review March 22, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

SerializationTest fails with Vaadin 25.1 due to missing jakarta.servlet-api

1 participant