Skip to content

[7154] Follow Up: Poor UX when editor is disabled in immersive mode#7180

Open
n-lark wants to merge 3 commits intomainfrom
7154-immersive-editor-disabled
Open

[7154] Follow Up: Poor UX when editor is disabled in immersive mode#7180
n-lark wants to merge 3 commits intomainfrom
7154-immersive-editor-disabled

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Apr 30, 2026

Description

Blocked by #7199

Replaces the raw "Cannot GET /" iframe response with a styled placeholder when the editor is disabled in immersive mode, plus a "Restart Required" state for the window between re-enabling and restart.

Screenshot 2026-04-30 at 12 40 27 PM
Screenshot 2026-04-30 at 12 40 36 PM

Related Issue(s)

Resolves #7154

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark requested a review from cstns April 30, 2026 19:41
@n-lark n-lark self-assigned this Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.62%. Comparing base (cabf53f) to head (de4f8b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7180   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files         405      405           
  Lines       20566    20566           
  Branches     4972     4972           
=======================================
  Hits        15758    15758           
  Misses       4808     4808           
Flag Coverage Δ
backend 76.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

:pendingStateChange="instance.pendingStateChange"
/>

<EmptyState v-else-if="isEditorDisabled" data-el="editor-disabled-empty-state">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ask @Yndira-E very nicely to create a couple of static lottie animations and treat these use cases as loadingScreenWrappers

we have frontend/src/images/lottie/immersive-editor-loading-states as examples, we should continue on that path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow Up: Poor UX when editor is disabled in immersive mode

2 participants