[6828] Pinia Task 11 - product-expert#6886
[6828] Pinia Task 11 - product-expert#6886n-lark wants to merge 14 commits into6827-pinia-task-10-product-expert-operator-agentfrom
Conversation
…t-operator-agent' into 6828-pinia-task-11-product-expert
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 6827-pinia-task-10-product-expert-operator-agent #6886 +/- ##
=================================================================================
Coverage 76.63% 76.63%
=================================================================================
Files 399 399
Lines 20167 20167
Branches 4856 4856
=================================================================================
Hits 15454 15454
Misses 4713 4713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…t-operator-agent' into 6828-pinia-task-11-product-expert
| shouldWakeUpAssistant (val) { | ||
| if (val) { | ||
| this.wakeUpAssistant({ shouldHydrateMessages: true }) | ||
| } |
There was a problem hiding this comment.
setContext previously lived in the root expert store and could trigger side effects directly. Moving it to a leaf store(see this comment on why) means components can no longer react to it implicitly. This watcher restores that reactivity on the team page.
| import { useAccountBridge } from './_account_bridge.js' | ||
| import { useProductExpertFfAgentStore } from './product-expert-ff-agent.js' | ||
|
|
||
| export const useProductExpertContextStore = defineStore('product-expert-context', { |
There was a problem hiding this comment.
Extracted from product-expert.js to break a circular import:
product-expert.js → product-assistant.js → messaging.service.js → product-expert.js.
By making this a leaf store, messaging.service.js can import it directly without closing the loop.
|
Hey @cstns while testing this I had some issues getting the immersive editor running - lets sync when you have time so I can test but everything else looked good testing. |
|
the product-expert store serves as a bus towards the ff-agent and ff-operator agents. 
these are the dynamic uses of them from the store, there might be more scattered across vue components as well |
…6828-pinia-task-11-product-expert
2 participants
Description
See details and test plan.
Items left:
Related Issue(s)
Resolves #6828
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel