Recycle items for ResultListBox #4218
Conversation
|
🥷 Code experts: jjw24 jjw24, Jack251970 have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
There was a problem hiding this comment.
Pull request overview
This pull request enables virtualization with recycling mode for the ResultListBox, which improves memory efficiency by reusing ListBoxItem containers instead of creating new ones for each data item. The changes update the selection logic and converters to work correctly with recycled containers by referencing data items instead of container instances.
Changes:
- Enabled virtualization recycling mode in the ResultListBox XAML
- Updated selection tracking to use ResultViewModel data items instead of ListBoxItem containers
- Modified OrdinalConverter and OpenResultHotkeyVisibilityConverter to use data-based indexing instead of container-based indexing
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Flow.Launcher/ResultListBox.xaml | Changed VirtualizationMode from "Standard" to "Recycling" and removed trailing whitespace |
| Flow.Launcher/ResultListBox.xaml.cs | Replaced ListBoxItem container tracking with ResultViewModel data tracking for recycling compatibility |
| Flow.Launcher/Converters/OrdinalConverter.cs | Changed from container-based to data-based index lookup with appropriate null handling |
| Flow.Launcher/Converters/OpenResultHotkeyVisibilityConverter.cs | Changed from container-based to data-based index lookup with appropriate null handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.