Skip to content

Validate Euclidean sampler integer arguments#2263

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/validate-euclidean-sampler-integer-args-20260525
May 25, 2026
Merged

Validate Euclidean sampler integer arguments#2263
FlorianPfaff merged 2 commits into
mainfrom
codex/validate-euclidean-sampler-integer-args-20260525

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Reject non-integral n_samples, n_candidates, n_points, and dimension arguments in the Euclidean deterministic samplers instead of silently truncating them with int(...).
  • Preserve integer-like scalar values such as 0-D NumPy integer arrays and finite floating scalars with exact integer value.
  • Add focused regression coverage for Fibonacci, Sobol, Halton, and rejection-sampler argument validation.

Rationale

The deterministic sampler APIs treat counts and dimensions as discrete quantities. Before this change, calls such as get_uniform_samples(2.5, 2) or sample_rejection(..., dim=1.5) were accepted and silently truncated to different problems, which can mask configuration errors and produce misleading sample sets.

Validation

  • Connector compare confirms this branch is 2 commits ahead of main and 0 behind.
  • Added tests/test_euclidean_sampler_integer_args.py.
  • Full local pytest could not be run because this execution environment cannot clone/fetch from github.com; repository CI should run the focused sampler tests and full suite.

@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 35.45s
✅ JSON prettier 7 0 0 0 0.83s
✅ JSON v8r 7 0 0 4.88s
✅ MARKDOWN markdownlint 66 0 0 0 1.75s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.79s
✅ PYTHON black 766 1 0 0 34.38s
✅ PYTHON isort 766 2 0 0 2.12s
✅ REPOSITORY checkov yes no no 42.07s
✅ REPOSITORY gitleaks yes no no 15.45s
✅ REPOSITORY git_diff yes no no 0.06s
✅ REPOSITORY secretlint yes no no 22.96s
✅ REPOSITORY syft yes no no 9.26s
✅ REPOSITORY trivy-sbom yes no no 4.56s
✅ REPOSITORY trufflehog yes no no 20.48s
✅ YAML prettier 11 0 0 0 0.68s
✅ YAML v8r 11 0 0 11.17s
✅ YAML yamllint 11 0 0 0.44s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 25, 2026 16:38
@FlorianPfaff FlorianPfaff merged commit 691a60a into main May 25, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant