Fix build in subdirectory #12
Conversation
Building in a subdirectory (by modifying local.sh) doesn't currently work. User overrides come too early (and don't actually override defaults) and defconfig target is not aware of the subdirectory. Fix it by defining a BUILD_DIR variable and by moving overrides after defaults. Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
|
Oh, forgot to mention that clangd only seems to be searching for *build subdirectories, so I had to change the subdirectory name to keep it working. |
| KERNEL_CMDLINE_EXTRA="init=/sbin/init-minimal $KERNEL_CMDLINE_EXTRA" | ||
| fi | ||
|
|
||
| # Let the user override environment variables for their special needs |
There was a problem hiding this comment.
Thanks Juri!
From a quick look, moving this block breaks at least the SKIP_SYSTEMD logic in the block just above. I'm thinking it could make sense to just have a BUILD_DIR variable that the user could override and with a default value of ".". Then we could use it as part of the existing default MAKE command and we wouldn't have to reorder these blocks. I think it'd be a bit more inline with the existing (whacky, I agree) logic, what do you think ?
I'm on holiday for a week so I'll only be able to give this a proper look in some time, apologies in advance if I'm not responsive ;)
2 participants
Building in a subdirectory (by modifying local.sh) doesn't currently work. User overrides come too early (and don't actually override defaults) and defconfig target is not aware of the subdirectory.
Fix it by defining a BUILD_DIR variable and by moving overrides after defaults.