Minor changes for the 2.4.0 release#299
Merged
sanguinariojoe merged 3 commits intoFloatingArrayDesign:devfrom Mar 28, 2025
Merged
Minor changes for the 2.4.0 release#299sanguinariojoe merged 3 commits intoFloatingArrayDesign:devfrom
sanguinariojoe merged 3 commits intoFloatingArrayDesign:devfrom
Conversation
tests/viv.cpp
Outdated
| cout << "Target Period: " << T << " s. Calculated period: " << peak_times[i]-peak_times[i-2] << " s" << endl; | ||
| // check that peak_times[i]-peak_times[i-2] is within TOL of T | ||
| CHECK_VALUE("Period", T, peak_times[i]-peak_times[i-2], TOL, peak_times[i]); // note that peak_times[i]-peak_times[i-1] would be a half period | ||
| cout << "Target Period: " << T |
Collaborator
There was a problem hiding this comment.
@sanguinariojoe, can you change this cout << <some text> to an INFO(<some text>) call? It was left over from debugging when I was building this test but would be nice to have if the test fails
Collaborator
|
@sanguinariojoe, thanks for running clang-format, thats been needed for a while. Agreed this is good to merge. I aded one comment about an inadvertent |
RyanDavies19
approved these changes
Mar 26, 2025
Collaborator
Author
|
OK then, I am merging and launching the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just ran clang-format and updated the CHANGELOG.md (I also fixed the links, which were pointing towards the fork, no the main repo).
I think we can merge this and launch the release