fix: remove Keep-Alive header that causes fetch failures in Node.js/Lambda #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ambda The Keep-Alive header with default value 'timeout=200' was causing all API requests to fail in Node.js environments (including AWS Lambda) because Node's undici HTTP client rejects this header as invalid. Error: InvalidArgumentError: invalid keep-alive header code: 'UND_ERR_INVALID_ARG' This removes the Keep-Alive header from all API requests and the keepAlive option from the Options and RequestOptions interfaces. Fixes DEVXP-74 Co-Authored-By: christopher.harrison@flatfile.io <cnharrison@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
Keep-Aliveheader that was introduced in v1.23.1, which causes all API requests to fail in Node.js 18+ environments (including AWS Lambda).The header
Keep-Alive: timeout=200is rejected by Node's undici HTTP client withInvalidArgumentError: invalid keep-alive header, causing requests to fail before they're even sent. This manifests asFlatfileError: fetch failedwithstatus: 0.Changes across 42 files:
Keep-Aliveheader from all API request headerskeepAliveoption fromOptionsandRequestOptionsinterfacesReview & Testing Checklist for Human
grep -r "Keep-Alive\|keepAlive" src/to confirm complete removalRecommended test plan: Install this branch in a Lambda function or Node 18+ project and verify API calls succeed where they previously failed with v1.23.1.
Notes