Open
Conversation
tomtzook
requested changes
Aug 31, 2021
Member
tomtzook
left a comment
tomtzook
left a comment
There was a problem hiding this comment.
Don't actually know much about swerve so I won't comment about the mathematics.
This should be tested though.
So I guess we will keep it waiting here until we get the chance.
.project
Outdated
| @@ -0,0 +1,28 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Member
There was a problem hiding this comment.
Regarding all those files:
Place them in .gitignore (can use the root one) and then you can run:
git rm [-r] --cached {file path}to remove them from git
| } | ||
|
|
||
| //this is bad, but I assume there is something built in, so I will wait for the PR on this one | ||
| public static double convertAngle(double angle) { |
Member
There was a problem hiding this comment.
To keep the degrees 0->360?
Mathf.translateAngle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
There are some things that I wasn't sure about, so I commented them, or did it in some way so you would correct it.
There is a little bit of code that still needs to be tested on a robot, but it's pretty straightforward. I will test it when I get the chance.
There are a lot of changes made to project files by vs code's Java extension.... Also, the wait a long time test fails on my machine for some reason. (unrelated to the changes)