fix(infra): Drop SECURE_PROXY_SSL_HEADER_NAME override#7499
Open
germangarces wants to merge 1 commit into
Open
fix(infra): Drop SECURE_PROXY_SSL_HEADER_NAME override#7499germangarces wants to merge 1 commit into
germangarces wants to merge 1 commit into
Conversation
Signed-off-by: germangarces <german.garces@flagsmith.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task definition pinned
SECURE_PROXY_SSL_HEADER_NAMEtoHTTP_CLOUDFRONT_FORWARDED_PROTO, so Django only detected HTTPS when the request came through CloudFront. Requests via the internal ALB (no CloudFront in the path) had no such header, sois_secure()returned False and Google SSO callbacks were generated ashttp://, which Google rejects.Removing the override falls back to the default in
api/app/settings/common.py:HTTP_X_FORWARDED_PROTO. Both ALBs stampX-Forwarded-Protoon their HTTPS listener, so Django detects HTTPS regardless of CloudFront presence.Contributes to #7282