Skip to content

feat: compare empty string display#7498

Open
Zaimwa9 wants to merge 3 commits into
mainfrom
feat/compare-empty-string-display
Open

feat: compare empty string display#7498
Zaimwa9 wants to merge 3 commits into
mainfrom
feat/compare-empty-string-display

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 12, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Display "" for empty values in compare view

How did you test this code?

  • Against staging

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 12, 2026 12:13
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team May 12, 2026 12:13
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment May 12, 2026 4:09pm
flagsmith-frontend-staging Ready Ready Preview, Comment May 12, 2026 4:09pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 12, 2026 4:09pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7498 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7498 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7498 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7498 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7498 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7498 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7498 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7498 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7498 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7498 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7498 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.3 seconds
commit  e041dd7
info  🔄 Run: #16707 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.5 seconds
commit  e041dd7
info  🔄 Run: #16707 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.8 seconds
commit  e041dd7
info  🔄 Run: #16707 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.4 seconds
commit  e041dd7
info  🔄 Run: #16707 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.1 seconds
commit  edf9b9c
info  🔄 Run: #16710 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  18 passed

Details

stats  18 tests across 14 suites
duration  1 minute, 9 seconds
commit  edf9b9c
info  🔄 Run: #16710 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.6 seconds
commit  edf9b9c
info  🔄 Run: #16709 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  49.1 seconds
commit  edf9b9c
info  🔄 Run: #16709 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  1 minute, 10 seconds
commit  edf9b9c
info  🔄 Run: #16709 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  37 seconds
commit  edf9b9c
info  🔄 Run: #16710 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  55.8 seconds
commit  edf9b9c
info  🔄 Run: #16709 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Visual Regression

16 screenshots compared. See report for details.
View full report

talissoncosta
talissoncosta previously approved these changes May 12, 2026
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is a much cleaner solution.

Quick question: would there be a strong reason not to make this the default everywhere rather than gating it behind isCompareEnv?

The original noise concern was about the [no value] chip rendering on every null row, which we've dropped. "" is rare enough that always rendering it shouldn't add meaningful noise to the features list — and it'd solve the same disambiguation problem on any future surface without per-caller opt-in.

Just raising as a discussion point, not blocking.

Image

@Zaimwa9
Copy link
Copy Markdown
Contributor Author

Zaimwa9 commented May 12, 2026

@talissoncosta added it in edf9b9c
image
Let me know your thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants