feat: compare empty string display#7498
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
Visual Regression16 screenshots compared. See report for details. |
talissoncosta
left a comment
There was a problem hiding this comment.
Looks good. This is a much cleaner solution.
Quick question: would there be a strong reason not to make this the default everywhere rather than gating it behind isCompareEnv?
The original noise concern was about the [no value] chip rendering on every null row, which we've dropped. "" is rare enough that always rendering it shouldn't add meaningful noise to the features list — and it'd solve the same disambiguation problem on any future surface without per-caller opt-in.
Just raising as a discussion point, not blocking.
|
@talissoncosta added it in edf9b9c |

Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
""for empty values in compare viewHow did you test this code?