fix(projects): validate organisation query param is numeric#7486
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Closes Flagsmith#7426 Signed-off-by: SAY-5 <say.apm35@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
@SAY-5 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
Closes #7426
`ProjectViewSet.get_queryset` passed the raw `?organisation=` query string straight into `queryset.filter(organisation__id=...)`. A non-numeric value bubbled up as an unhandled `ValueError` from `IntegerField.get_prep_value`, producing a 500 in Sentry (FLAGSMITH-API-5NT).
Validate the parameter is an integer and raise DRF `ValidationError` (400) otherwise. Mirrors the same pattern used elsewhere in the codebase.
How did you test this code?
Added `test_list_projects__non_numeric_organisation__returns_400` to `test_unit_projects_views.py` covering the exact Sentry repro string.