Skip to content

feat(Features API): Restrict code references querying to a feature flag#6970

Open
emyller wants to merge 1 commit intomainfrom
feat/hide-code-references-querying-under-flag
Open

feat(Features API): Restrict code references querying to a feature flag#6970
emyller wants to merge 1 commit intomainfrom
feat/hide-code-references-querying-under-flag

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Mar 17, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #6945

  • Don't query code references unless code_references_ui_stats is enabled.
  • Suggest a new util is_feature_enabled we should use more often!

Important

Also needs to review and merge #6968 — order is not critical.

How did you test this code?

  • Added unit tests to is_feature_enabled.
  • Verified changes in the frontend.

@emyller emyller self-assigned this Mar 17, 2026
@claude
Copy link

claude bot commented Mar 17, 2026

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Mar 17, 2026 4:04am
flagsmith-frontend-staging Ready Ready Preview, Comment Mar 17, 2026 4:04am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Mar 17, 2026 4:04am

Request Review

@emyller emyller requested review from a team as code owners March 17, 2026 04:04
@emyller emyller requested review from khvn26 and talissoncosta and removed request for a team March 17, 2026 04:04
@emyller emyller changed the title Restrict code references querying to a feature flag feat(FeaturesAPI ): Restrict code references querying to a feature flag Mar 17, 2026
@emyller emyller changed the title feat(FeaturesAPI ): Restrict code references querying to a feature flag feat(Features API): Restrict code references querying to a feature flag Mar 17, 2026
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API labels Mar 17, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6970 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6970 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-6970 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-6970 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6970 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6970 Finished ✅ Results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  28.3 seconds
commit  8cdf16b
info  🔄 Run: #15318 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  27.8 seconds
commit  8cdf16b
info  🔄 Run: #15318 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  1 minute, 1 second
commit  8cdf16b
info  🔄 Run: #15318 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  55.9 seconds
commit  8cdf16b
info  🔄 Run: #15318 (attempt 1)

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.31%. Comparing base (0d68a05) to head (8cdf16b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6970   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files        1335     1335           
  Lines       49760    49793   +33     
=======================================
+ Hits        48923    48956   +33     
  Misses        837      837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant