Skip to content

fix: Fix "unsaved changes" badge positioning on Edit Feature modal tabs #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiwaniZakir wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −6
Open

fix: Fix "unsaved changes" badge positioning on Edit Feature modal tabs #6969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c10dbf
fix: align unsaved changes badge vertically on Edit Feature modal tab…
JiwaniZakir Mar 17, 2026
2be3757
fix: remove unrelated bottom: 0 addition from .unread in _tabs.scss
JiwaniZakir Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/web/components/modals/create-feature/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ const Index = class extends Component {
tabLabelString='Segment Overrides'
tabLabel={
<Row
className={`justify-content-center ${
className={`justify-content-center align-items-center ${
Copy link

@cursor cursor bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment fix applied to only one of three tabs

Medium Severity

The align-items-center fix is only applied to the Segment Overrides tab Row, but the Value tab (line 850) and Settings tab (line 1679) use the identical Row + unsaved-changes badge pattern with only justify-content-center. Before this change, all three badge tabs were equally misaligned; now only Segment Overrides is corrected, creating a visible inconsistency between tabs with unsaved changes indicators.

Fix in Cursor Fix in Web

this.state.segmentsChanged
? 'pr-1'
: ''
Expand Down
8 changes: 3 additions & 5 deletions frontend/web/styles/components/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@
}
.hljs-container {
code {

padding-top: 80px;
}
.react-select {
position: absolute;
top:16px;
left:16px;
top: 16px;
left: 16px;
}
}
}
Expand Down Expand Up @@ -115,10 +114,9 @@
}
}


.tabs {
& .pill {
background-color:$pill-bg;
background-color: $pill-bg;
border-radius: $border-radius-xlg;
display: inline-block;
button,
Expand Down
Loading