fix: convert feature_state_value after v2 segment save (#6962)#6967
Open
talissoncosta wants to merge 1 commit intomainfrom
Open
fix: convert feature_state_value after v2 segment save (#6962)#6967talissoncosta wants to merge 1 commit intomainfrom
talissoncosta wants to merge 1 commit intomainfrom
Conversation
…6962) The v2 segment save path stores the API response's feature_state_value as a FeatureStateValue object instead of converting it to a primitive, causing [object Object] to appear in the UI. The VALUE path already handles this correctly — this aligns the SEGMENT path to do the same. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
front-end
|
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage. Once credits are available, reopen this pull request to trigger a review. |
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Closes #6962
After saving segment overrides on a v2 versioned environment, the
getVersionFeatureStateAPI returnsfeature_state_valueas aFeatureStateValueobject (e.g.{type: "unicode", string_value: "hello", ...}). The v2 segment save path infeature-list-store.tswas storing this raw object in the model, causing the UI to render[object Object]instead of the actual value.The v2 VALUE save path (line 820) already converts correctly using
Utils.featureStateToValue()— this PR aligns the SEGMENT path to do the same.How did you test this code?
[object Object])