chore: remove unused dead code#6953
chore: remove unused dead code#6953matthewelwell merged 2 commits intoFlagsmith:chore/remove-dead-codefrom
Conversation
|
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage. Once credits are available, reopen this pull request to trigger a review. |
|
@duriantaco is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/remove-dead-code #6953 +/- ##
==========================================================
- Coverage 98.31% 98.25% -0.06%
==========================================================
Files 1335 1333 -2
Lines 49745 49583 -162
==========================================================
- Hits 48907 48718 -189
- Misses 838 865 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thanks for the contribution @duriantaco! I'm going to merge this into a branch in our own repository so that the currently failing CI checks pass can be run. It might be that some of this code is required by some of our private packages which are hosted in private repositories and installed at build time. |
4c14dd4
into
Flagsmith:chore/remove-dead-code
|
I have opened #6955 which you can follow. |
Summary
Changes
WebhookSendErrorwebhooks/exceptions.py(deleted)WebhookURLSerializerwebhooks/serializers.pyViewResponseDoesNotHaveStatussse/exceptions.pyImproperlyConfiguredErrorapp/exceptions.py(deleted)IdentitySerializerFullenvironments/identities/serializers.pyBaseDetailedPermissionsSerializerpermissions/serializers.pyUTMDataModelusers/models.pyDispatchResponsecustom_auth/mfa/trench/responses.pyOAuthErrorcustom_auth/oauth/exceptions.pyGithubError/GoogleErrorkept)get_next_segment_priorityfeatures/models.pyAlso removes now-unused imports (
EnvironmentSerializerFull,FeatureStateSerializerFull,pydantic.BaseModel).Test plan
Found with Skylos — dead code detection for Python.