refactor: decouple Button from Constants import#6947
Open
talissoncosta wants to merge 1 commit intomainfrom
Open
refactor: decouple Button from Constants import#6947talissoncosta wants to merge 1 commit intomainfrom
talissoncosta wants to merge 1 commit intomainfrom
Conversation
Replace Constants.colours lookup with a local iconColours map, removing the transitive dependency on common/constants → common/project.js → common/data/base/_data.js. This unblocks Button rendering in Storybook and other environments where those CJS modules are not available. Only two icon colours are used in practice: 'white' and 'primary'. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
front-end
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
Contributes to #6892
Replace
Constants.colourslookup inButton.tsxwith a localiconColoursmap, removing the transitive dependency chain:common/constants→common/project.js→common/data/base/_data.js.Only two icon colours are used across all call sites:
'white'and'primary'. The new local map provides exactly those values with no external imports.This unblocks Button rendering in Storybook and other environments where those CJS modules are not available.
How did you test this code?
npx eslint --fix— no lint errorsnpm run typecheck— no new type errors (all 3 call sites type-safe:iconLeftColour='white',iconRightColour='primary')JSONReference.tsx,EditIdentity.tsx, andCodeHelp.jsare unchanged in behaviour🤖 Generated with Claude Code