fix: address review comments on React 19 migration#6940
Open
talissoncosta wants to merge 7 commits intodeps/upgrade-to-react-19from
Open
fix: address review comments on React 19 migration#6940talissoncosta wants to merge 7 commits intodeps/upgrade-to-react-19from
talissoncosta wants to merge 7 commits intodeps/upgrade-to-react-19from
Conversation
- Restore shouldCancelStart behaviour for segment override drag-and-drop by using a custom PointerSensor that cancels on interactive elements - Add tooltip show delay (500ms) to match previous fade-in UX - Replace opacity: 1 !important with react-tooltip v5 CSS custom properties Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The base .chip class was missing display: flex and align-items: center, causing the close icon to wrap below the chip text. The --sm and --xs variants already had this styling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The custom ChipInput replacement was missing the backspace key handler that material-ui-chip-input provided out of the box. Pressing backspace when the input is empty now removes the last chip. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
react-tooltip v5 applies font-size: 90% by default, shrinking tooltip text compared to v4. Doubling the selector (.react-tooltip.react-tooltip) increases specificity to ensure our $font-size-sm is applied. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace @dnd-kit/core + @dnd-kit/sortable + @dnd-kit/utilities with @dnd-kit/react + @dnd-kit/helpers + @dnd-kit/abstract. The new API handles transforms automatically, uses handleRef for drag handles, and RestrictToVerticalAxis modifier for axis locking. The header area of each segment override card is now the drag handle, keeping the actions menu and form controls fully interactive. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unused ConfigProvider HOC wrapping - Remove excessive inline zIndex (9999999999) - Replace inline styles with .drag-handle CSS class - Use classNames() for className concatenation - Extract getSegmentId() helper for safe segment ID access - Simplify Fragment keys to use stable sortId Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Shared hook for animating height expand/collapse transitions, replacing duplicated rAF logic in CollapsibleText and AccordionCard. Also fixes missing rAF cleanup in CollapsibleText. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
front-end
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Contributor
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #6764
Addresses all review comments on the React 19 migration PR. Built on top of Wadii's
deps/upgrade-to-react-19branch.Drag-and-drop (SegmentOverrides):
@dnd-kit/core+@dnd-kit/sortableto@dnd-kit/react(newer API with cleaner handle support)RestrictToVerticalAxismodifierConfigProviderHOC wrappingclassNames()for className concatenationgetSegmentIdhelper)Tooltip (react-tooltip v5):
delayShow)!important)--rt-opacity: 1and--rt-transition-show-delay: 0.2sChipInput:
display: flex; align-items: center)Shared hook:
useCollapsibleHeighthook fromAccordionCardandCollapsibleTextCollapsibleTextHow did you test this code?
Manually tested on staging: