fix: mask webhook secret with password field and reveal toggle#6932
Open
talissoncosta wants to merge 2 commits intomainfrom
Open
fix: mask webhook secret with password field and reveal toggle#6932talissoncosta wants to merge 2 commits intomainfrom
talissoncosta wants to merge 2 commits intomainfrom
Conversation
Changes the secret input from type='text' to type='password' in both environment and audit log webhook forms. The Input component already provides an eye/eye-off toggle for password fields. Closes #6724 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
bot
added
front-end
Contributor
Docker builds report
|
The eye icon was inverted — showing eye-off when hidden and eye when visible. Now shows eye (click to reveal) when masked, and eye-off (click to hide) when visible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Closes #6724
Webhook secret masking
The webhook secret was displayed as plain text when editing an existing webhook. Changed the secret input from
type='text'totype='password'in both environment and audit log webhook forms.The existing
Inputcomponent already provides a built-in eye/eye-off toggle button for password fields, so the secret is now:•••••)Files changed:
CreateWebhook.tsx— environment webhook secret inputCreateAuditLogWebhook.tsx— audit log webhook secret inputEye icon logic fix
While implementing the above, we found the eye/eye-off icon logic in
Input.jswas inverted — it showedeye-off(crossed eye) when the field was hidden, andeye(open eye) when visible. This affected all password fields across the app.Fixed to follow the standard convention:
eyeicon (click to reveal)eye-officon (click to hide)File changed:
Input.js— swapped icon conditionHow did you test this code?
eyewhen masked,eye-offwhen revealed🤖 Generated with Claude Code