refactor: Prevent duplicate features list GETS#6927
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Failed testsfirefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss Details
Failed testsfirefox › tests/change-request-test.pw.ts › Change Request Tests › Change requests can be created, approved, and published with 4-eyes approval @enterprise Details
Failed testsfirefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss Details
Failed testsfirefox › tests/change-request-test.pw.ts › Change Request Tests › Change requests can be created, approved, and published with 4-eyes approval @enterprise Details
Failed testsfirefox › tests/segment-test.pw.ts › Segment test 1 - Create, update, and manage segments with multivariate flags @oss Details
Failed testsfirefox › tests/segment-test.pw.ts › Segment test 1 - Create, update, and manage segments with multivariate flags @oss Details
Failed testsfirefox › tests/segment-test.pw.ts › Segment test 1 - Create, update, and manage segments with multivariate flags @oss Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
|
Hey @kyle-ssg , great work!! I found a pre-existing bug while testing this PR (also reproduces on main): Bug: Typing only whitespace (e.g. a space) in the search or value search filter sends search=%20 to the API, which returns a 400 "This field may not be blank.". On main, this also triggers a hard redirect to /404?entity=environment because the Flux store's catch block treats any error as a permission issue. I've opened #6934 on top of your branch to fix it — it trims search values at the source in useFeatureFilters so whitespace-only input never triggers a state change or API request. |
…een environments
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Uses RTK cache for feature list to reduce latency, long term solution will be to migrate fully away from the flux store but in the meantime this is a win.
Left = After (1 request instead of multiple)
Also adds loading indication between environment where we treat switching environment + fetching = loading
How did you test this code?