refactor: create feature migration by kyle-ssg · Pull Request #6925 · Flagsmith/flagsmith

kyle-ssg · 2026-03-11T15:21:57Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Migrates all tabs including the create feature modal itself to TypeScript, no type errors to do with creating / editing a feature and also reduces the feature modal by ~1200 LoC.

Migrates a few components to ES export

How did you test this code?

E2E was extended to cover more of the feature management process specifically for this PR
Created / edited features in production

# Conflicts: # frontend/web/components/modals/create-feature/index.js # frontend/web/components/pages/FeaturesPage.js

# Conflicts: # frontend/package-lock.json # frontend/package.json # frontend/web/components/modals/create-feature/index.js

# Conflicts: # .github/workflows/.reusable-docker-e2e-tests.yml # frontend/.claude/context/e2e.md # frontend/Makefile # frontend/api/index.js # frontend/e2e/global-setup.playwright.ts # frontend/e2e/helpers/e2e-helpers.playwright.ts # frontend/e2e/tests/change-request-test.pw.ts # frontend/e2e/tests/flag-tests.pw.ts # frontend/e2e/tests/invite-test.pw.ts # frontend/e2e/tests/organisation-test.pw.ts # frontend/e2e/tests/project-permission-test.pw.ts # frontend/e2e/tests/project-test.pw.ts # frontend/e2e/tests/segment-test.pw.ts # frontend/e2e/tests/versioning-tests.pw.ts # frontend/package-lock.json

… package for npm

…tion-continued # Conflicts: # frontend/web/components/modals/create-feature/index.js # frontend/web/components/modals/create-feature/tabs/CreateFeatureTab.tsx # frontend/web/components/modals/create-feature/tabs/FeatureSettingsTab.tsx # frontend/web/components/modals/create-feature/tabs/FeatureValue.tsx

vercel · 2026-03-11T15:22:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview, Comment	Mar 11, 2026 3:26pm
flagsmith-frontend-staging	Ready	Preview, Comment	Mar 11, 2026 3:26pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Mar 11, 2026 3:26pm

github-actions · 2026-03-11T15:23:16Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-e2e:pr-6925`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-e2e:pr-6925`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api-test:pr-6925`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-6925`	Finished ✅	Results ✅

github-actions · 2026-03-11T15:29:53Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
11.9 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
48 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

16 passed

Details

16 tests across 13 suites
1 minute, 7 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
48.9 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
49.5 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
1 minute, 17 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
54.2 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 2 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

talissoncosta · 2026-03-11T20:53:04Z

frontend/web/components/modals/create-feature/tabs/IdentityOverridesTab.tsx

+        const envId = project?.environments?.find(
+          (env) => env.api_key === environmentId,
+        )?.id
+        if (!envId) {
+          setUserOverridesNoPermissionState()
+          return
+        }


I think I might have found a bug

This is comparing api_key (a string like "RAvjEqbj96SXiJP4hQHd5E") with environmentId which is now a numeric ID (e.g. "123") after #6322. They'll never match, so it always falls into the no-permission state.

environmentId is already the numeric ID, so this lookup can be removed and environmentId passed directly to getPermission.

I am getting this:

talissoncosta · 2026-03-11T20:57:01Z

frontend/web/components/modals/create-feature/tabs/IdentityOverridesTab.tsx

+        getPermission(
+          getStore(),
+          {
+            id: envId,
+            level: 'environment',
+          },
+          { forceRefetch },
+        )


Suggested change

getPermission(

getStore(),

{

id: envId,

level: 'environment',

},

{ forceRefetch },

)

getPermission(

getStore(),

{

id: environmentId,

level: 'environment',

},

{ forceRefetch },

)

it seems to do the trick

talissoncosta · 2026-03-11T21:18:55Z

frontend/web/components/modals/create-feature/tabs/SegmentOverridesTab.tsx

+  const environment = project?.environments?.find(
+    (env) => env.api_key === environmentId,
+  )


Same api_key vs numeric ID issue as above — environment is always undefined, so isVersioned and is4Eyes are always false. This silently bypasses 4-eyes/change requests for segment overrides.

Suggested change

const environment = project?.environments?.find(

(env) => env.api_key === environmentId,

)

const environment = getEnvironment(environmentId)

talissoncosta · 2026-03-11T21:23:21Z

frontend/web/components/modals/create-feature/tabs/IdentityOverridesTab.tsx

+          userOverridesPage(1)
+        })
+        .catch(() => {
+          setIsLoading(false)


What do you think about adding setUserOverridesErrorState in here as well to avoid silent errors ?

Suggested change

setIsLoading(false)

setIsLoading(false)

setUserOverridesErrorState()

kyle-ssg added 30 commits January 13, 2026 12:20

Typo

4011328

Fix alert infinite callback

4e3f18e

feat: edit versioned change request (#6368)

08b2d34

Merge branch 'main' into chore/create-flag-migration

a9d9be3

# Conflicts: # frontend/web/components/modals/create-feature/index.js # frontend/web/components/pages/FeaturesPage.js

Fix conflict

a0960f3

Pass identity override to variation options

272cce3

Adjust feature state prop

2a5ce5c

Merge branch 'main' into chore/create-flag-migration

474689b

Simplify create feature for identity/environment

74b83fa

Playwright

56d52ed

Playwright

c9f792e

Remove unused tests

a50bb05

Merge branch 'main' into chore/playwright

155a2c6

# Conflicts: # frontend/package-lock.json # frontend/package.json # frontend/web/components/modals/create-feature/index.js

Merge package lock

184194e

Use playwright's firefox in dockerfile

6448d43

Add frontend makefile logging, remove apt-get line

00ef9f7

re-add "tags" to tests

0606454

Add health check prior to teardown

5ccaa96

Add health check prior to teardown

145056b

Add health check prior to teardown

bab12a1

Improve logging, add sticky comment, add artifcats

97adfcb

Fix duplicate artifacts / race conditions

9bcb51d

improve artifacts

3058590

improve artifacts

8bfd940

improve tests

ae098f8

fix duplicate artifact names, only upload artifacts on failure

36e733e

Remove testcafe stuff

72e262e

Fix piping

c28be83

Cut down noise

7397500

Revert teardown token logic

72a9a42

kyle-ssg added 8 commits February 25, 2026 17:27

Add tabs, remove old code, fix types

ceef160

Migrate flagsmith to @Flagsmith/flagsmith and @flagsmith/react-native…

b01145d

… package for npm

Migrate create flag

d393f10

Migrate create flag

8bd06b7

Fix permission check

12f29a8

Fix permission check

f1c6066

kyle-ssg requested a review from a team as a code owner March 11, 2026 15:21

kyle-ssg requested review from talissoncosta and removed request for a team March 11, 2026 15:21

vercel bot deployed to Preview – flagsmith-frontend-preview March 11, 2026 15:22 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging March 11, 2026 15:22 View deployment

kyle-ssg changed the base branch from main to chore/permission-types March 11, 2026 15:22

github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Mar 11, 2026

Comment

ba41b02

matthewelwell changed the title ~~chore: create feature migration~~ refactor: create feature migration Mar 11, 2026

github-actions bot added chore and removed chore labels Mar 11, 2026

vercel bot deployed to Preview – flagsmith-frontend-staging March 11, 2026 15:26 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview March 11, 2026 15:26 View deployment

talissoncosta reviewed Mar 11, 2026

View reviewed changes

talissoncosta requested changes Mar 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: create feature migration#6925

refactor: create feature migration#6925
kyle-ssg wants to merge 132 commits intochore/permission-typesfrom
chore/create-feature-migration-continued

kyle-ssg commented Mar 11, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	setIsLoading(false)
	setIsLoading(false)
	setUserOverridesErrorState()

Conversation

kyle-ssg commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercel bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kyle-ssg commented Mar 11, 2026 •

edited

Loading

vercel bot commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading