feat: Stream S3 organisation exports #6612
Open
+496
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
github-actions
bot
added
feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6612 +/- ##
==========================================
+ Coverage 98.18% 98.22% +0.04%
==========================================
Files 1295 1298 +3
Lines 46920 47047 +127
==========================================
+ Hits 46067 46212 +145
+ Misses 853 835 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
feature
khvn26
force-pushed
the
feat/streaming-s3-export
branch
from
9fdb083 to
502c108
Compare
github-actions
bot
added
feature
github-actions
bot
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #6610.
In this PR, we avoid OOM worker terminations when attempting to export beefy organisations via the sales dashboard.
We assume that using generators and multipart S3 uploads should significantly reduce the memory footprint. The tradeoff is that the exports should take slightly longer.
How did you test this code?
All the new code and changes to existing code are covered with tests. This will be tested manually on staging.