Merged
Conversation
khvn26
requested changes
Oct 23, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Looks good, with a handful of comments.
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
Zaimwa9
commented
Nov 10, 2025
khvn26
requested changes
Nov 10, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Looks good on the whole. Just two comments.
Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
gagantrivedi
requested changes
Nov 11, 2025
gagantrivedi
previously approved these changes
Nov 11, 2025
Contributor
|
This should be |
khvn26
previously approved these changes
Nov 11, 2025
* feat: added-engine-function-signatures * feat: moved-engine-to-core * feat: implemented-process-segment-overrides * feat: implemented-evalute-segments-partially * feat: implemented-should-apply-override * feat: implemented-get-identity-segments * feat: implemented-new-in-and-fixed-remaining-tests * feat: run-lint * feat: misc * feat: json-path-lib-implementation * remove dup * feat: made-legacy-functions-public * feat: updated-tests-to-match-engine-in-operator-accepting-numbers * feat: engine-agnostic-to-empty-identity-in-segment-evaluation * feat: renamed-to-is-higher-priority * feat: renamed-get-identity-segments-func * feat: reverted-to-is-primitive * feat: use-weakest-priority-constant * feat: upgraded-engine-test-data-and-fixed-mv-evaluation-bug * feat: removed-targeting-reason-func * feat: linter-rubocop-autocorrect * feat: linter * feat: linter * feat: moved-mappers-to-engine-namespace * feat: enrich-context-with-identity-key * feat: run-ci-on-all-branches * feat: removed-comments * feat!: sdk consumes context engine (#89) * fix: sdk-uses-new-engine-methods * feat: introduced-jsonpath-library * feat: fixed-conflict * Update lib/flagsmith/engine/segments/models.rb Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> * Update lib/flagsmith/engine/segments/models.rb * feat: removed-normalize * feat: linter * feat: replaced-flagsmith-id-with-id * feat: removed-comments --------- Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com> --------- Co-authored-by: Gagan Trivedi <gagandeeptrivedi47@gmail.com> Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
Zaimwa9
changed the title
gagantrivedi
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Contributes to #81
This is pass 1 of 4.
map_environment_model_to_evaluation_context,map_identity_overrides_to_segments,map_segment_rule_to_model,map_identity_model_to_identity_context)How did you test this code?