fix: get_environment_flags includes segments in evaluation context

[Copilot]

Fix for issue #6051: Omit segments from evaluation context when get_environment_flags is called

This change addresses the issue where segments were unnecessarily included in the evaluation context when retrieving environment flags. Segments are only relevant for identity-specific evaluations, not for environment-wide flag evaluations.

Changes made:

• Modified _get_environment_flags_from_document() to filter out segments from the evaluation context before passing it to the engine
• Simplified implementation using copy() and pop() instead of dictionary comprehension
• Uses consistent keyword argument style (context=...) for all engine.get_evaluation_result calls
• Added comprehensive tests with proper fixtures and mocking

Testing & Quality:

• ✅ All existing tests pass (73 tests)
• ✅ All linters pass (black, isort, flake8, mypy)
• ✅ Code review feedback addressed

Impact:

• Improves performance by reducing unnecessary data in the evaluation context for environment flags
• Maintains backward compatibility - no API changes
• Segments continue to work correctly for identity-specific evaluations

Ready for review!

Original prompt

---

This section details on the original issue you should resolve

<issue_title>get_environment_flags includes segments in evaluation context</issue_title>
<issue_description>See Flagsmith/flagsmith#6051.

In the mapper layer, omit segments from evaluation context when get_environment_flags is called.</issue_description>

<agent_instructions>use conventional-commit for PR title:
fix:

add a new test — perhaps by adding test_mappers.py

verify with pytest and pre-commit run -a</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes get_environment_flags includes segments in evaluation context #172

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[khvn26]

@copilot Please address the review comments above.

[Copilot]

@copilot Please address the review comments above.

All review comments addressed in 10242fb. Changes include:

• Using local_eval_flagsmith fixture
• Mocking specific function with autospec=True
• Using assert_called_once_with for cleaner assertions
• Simplified context filtering with copy() and pop()

All tests pass (73/73) and linters are clean.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• test_urlanalytics
  • Triggering command: /home/REDACTED/.cache/pypoetry/virtualenvs/flagsmith-K6knkhUn-py3.12/bin/python /home/REDACTED/.cache/pypoetry/virtualenvs/flagsmith-K6knkhUn-py3.12/bin/pytest tests/ -x (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[khvn26]

Yup, LGTM.

[emyller]

This was easier to comprehend by reading the code, than from the overly verbose and situation-contextualized PR description. 😞

Changes LGTM