Merged
Conversation
khvn26
changed the title
khvn26
force-pushed
the
feat/support-feature-metadata
branch
from
65768e3 to
e4616f0
Compare
khvn26
force-pushed
the
feat/support-feature-metadata
branch
from
e4616f0 to
fdc89d6
Compare
emyller
previously requested changes
Oct 16, 2025
Contributor
emyller
left a comment
emyller
left a comment
There was a problem hiding this comment.
Looks good overall! Couple questions.
matthewelwell
approved these changes
Oct 22, 2025
Contributor
|
Approved based on Evandro's review, and having reviewed the remaining commits added since. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we pass the Flagsmith feature id as part of engine feature metadata.
Review difficulty: 2/5